New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when searching for .* #134

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@achesak
Contributor

achesak commented Nov 4, 2016

Fixes #95.

There are two parts to this fix:

  • There is a check for when the previous and next matches have flipped fields, as this happens infinitely when dot-star is used.

  • dot-star is changed to dot. The previous behavior of dot-star was to get stuck on matching the entire first line, which did not make sense given what the pattern is supposed to match. Changing this pattern to dot results in a more sane match, either the previous or next character.

@dom96

This comment has been minimized.

Show comment
Hide comment
@dom96

dom96 Nov 4, 2016

Member

Wouldn't it make more sense for .* to match the whole file?

Member

dom96 commented Nov 4, 2016

Wouldn't it make more sense for .* to match the whole file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment