{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":842037,"defaultBranch":"devel","name":"Nim","ownerLogin":"nim-lang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-08-16T20:38:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/603863?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715201644.0","currentOid":""},"activityList":{"items":[{"before":"497db424b7aea30d397c7877a196eb9a5ce6076c","after":"52fbdfa64929deb65cebe7f243c147e02227fac8","ref":"refs/heads/gh-pages","pushedAt":"2024-05-08T21:03:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy to GitHub pages","shortMessageHtmlLink":"Deploy to GitHub pages"}},{"before":"5528789afa767d99a6101b4e1bf64c44a7f1b43f","after":null,"ref":"refs/heads/pr_distinct_destructor","pushedAt":"2024-05-08T20:54:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"}},{"before":"63398b11f51529d8a3350853fcf7b7a1cf522b7a","after":"2995a0318be391097f17cb764556294dca5695e8","ref":"refs/heads/devel","pushedAt":"2024-05-08T20:54:03.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"fixes #23552; Invalid codegen when trying to mannualy delete distinct seq (#23558)\n\nfixes #23552","shortMessageHtmlLink":"fixes #23552; Invalid codegen when trying to mannualy delete distinct…"}},{"before":"d8e1504ed1fd2371f2ab7784c0f4b5f6376325a5","after":"63398b11f51529d8a3350853fcf7b7a1cf522b7a","ref":"refs/heads/devel","pushedAt":"2024-05-08T20:53:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"Add a note about the sideeffect pragma (#23543)","shortMessageHtmlLink":"Add a note about the sideeffect pragma (#23543)"}},{"before":"09bd9d0b19a69a56b875eff6e6d119aaf67664fd","after":"d8e1504ed1fd2371f2ab7784c0f4b5f6376325a5","ref":"refs/heads/devel","pushedAt":"2024-05-08T20:53:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"Add Complex version of almostEqual function (#23549)\n\nThis adds a version of `almostEqual` (which was already available for\r\nfloats) thata works with `Complex[SomeFloat]`.\r\n\r\nProof that this is needed is that the first thing that the complex.nim\r\nrunnable examples block did before this commit was define (an\r\nincomplete) `almostEqual` function that worked with complex values.","shortMessageHtmlLink":"Add Complex version of almostEqual function (#23549)"}},{"before":"526e48b2ed2ee3e9dad9d61c1f3a96444225ebc4","after":"5cecd81a05de0f3db3d77407e70a33d65bd9df2c","ref":"refs/heads/version-2-0","pushedAt":"2024-05-08T16:42:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"narimiran","name":"Miran","path":"/narimiran","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16516130?s=80&v=4"},"commit":{"message":"fix semFinishOperands for bracket expressions [backport:2.0] (#23571)\n\nfixes #23568, fixes #23310\n\nIn #23091 `semFinishOperands` was changed to not be called for `mArrGet`\nand `mArrPut`, presumably in preparation for #23188 (not sure why it was\nneeded in #23091, maybe they got mixed together), since the compiler\nhandles these later and needs the first argument to not be completely\n\"typed\" since brackets can serve as explicit generic instantiations in\nwhich case the first argument would have to be an unresolved generic\nproc (not accepted by `finishOperand`).\n\nIn this PR we just make it so `mArrGet` and `mArrPut` specifically skip\ncalling `finishOperand` on the first argument. This way the generic\narguments in the explicit instantiation get typed, but not the\nunresolved generic proc.\n\n(cherry picked from commit 09bd9d0b19a69a56b875eff6e6d119aaf67664fd)","shortMessageHtmlLink":"fix semFinishOperands for bracket expressions [backport:2.0] (#23571)"}},{"before":"f96a1aa86f62ab71fbb6fc85327a987a778cc48e","after":"497db424b7aea30d397c7877a196eb9a5ce6076c","ref":"refs/heads/gh-pages","pushedAt":"2024-05-08T15:45:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy to GitHub pages","shortMessageHtmlLink":"Deploy to GitHub pages"}},{"before":"e6f66e4d131fb8cf3236df6cb14e219dbb5d0c77","after":"09bd9d0b19a69a56b875eff6e6d119aaf67664fd","ref":"refs/heads/devel","pushedAt":"2024-05-08T15:35:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"fix semFinishOperands for bracket expressions [backport:2.0] (#23571)\n\nfixes #23568, fixes #23310\r\n\r\nIn #23091 `semFinishOperands` was changed to not be called for `mArrGet`\r\nand `mArrPut`, presumably in preparation for #23188 (not sure why it was\r\nneeded in #23091, maybe they got mixed together), since the compiler\r\nhandles these later and needs the first argument to not be completely\r\n\"typed\" since brackets can serve as explicit generic instantiations in\r\nwhich case the first argument would have to be an unresolved generic\r\nproc (not accepted by `finishOperand`).\r\n\r\nIn this PR we just make it so `mArrGet` and `mArrPut` specifically skip\r\ncalling `finishOperand` on the first argument. This way the generic\r\narguments in the explicit instantiation get typed, but not the\r\nunresolved generic proc.","shortMessageHtmlLink":"fix semFinishOperands for bracket expressions [backport:2.0] (#23571)"}},{"before":"e662043fd1c43e8447fb7c30e97823f7d0a46a83","after":"e6f66e4d131fb8cf3236df6cb14e219dbb5d0c77","ref":"refs/heads/devel","pushedAt":"2024-05-08T15:33:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"fixes 12381, HttpClient socket handle leak (#23575)\n\n## Bug\r\n\r\nFixes https://github.com/nim-lang/Nim/issues/12381 - HttpClient socket\r\nhandle leak\r\n\r\nTo replicate the bug, run the following code in a loop:\r\n\r\n```nim\r\nimport httpclient\r\nwhile true:\r\n echo \"New loop\"\r\n var client = newHttpClient(timeout = 1000)\r\n try:\r\n let response = client.request(\"http://10.44.0.4/bla\", httpMethod = HttpPost, body = \"boo\")\r\n echo \"HTTP \" & $response.status\r\n except CatchableError as e:\r\n echo \"Error sending logs: \" & $e.msg\r\n finally:\r\n echo \"Finally\"\r\n client.close()\r\n```\r\n\r\nNote the IP address as the hostname. I'm directly connecting to a\r\nplausible local IP, but one that does not resolve, as I have everything\r\nunder 10.4.x.x.\r\n\r\nThe output looks like this to me:\r\n\r\n```\r\nNew loop\r\nError sending logs: Operation timed out\r\nFinally\r\nNew loop\r\nError sending logs: Operation timed out\r\nFinally\r\nNew loop\r\n...\r\n```\r\n\r\nIn Nim 2.0.4, running the code above leaks the socket:\r\n\r\n\"Screenshot\r\n\r\n## Fix\r\n\r\nWith the added line of code, each old socket is cleanly removed:\r\n\r\n\"Screenshot\r\n\r\nI believe the line below, `closeUnusedFds(ord(domain))` was supposed to\r\nclean up the failed connection attempts, but it failed to do so for the\r\nlast one, assuming it succeeded. Yet it didn't. This fix makes sure\r\nfailed connections are closed immediately.\r\n\r\n## Tests \r\n\r\nI don't have a test with this PR. When testing locally, the\r\n`connect(lastFd, ..)` call on line 2032 blocks for ~75 seconds, ignoring\r\nthe http timeout. I fear any test I could add would either 1) take way\r\ntoo long, 2) one day run in an environment where my randomly chosen IP\r\nis real, yielding in weird flakes.\r\n\r\nThe only bug i can imagine is if running `lastFd.close()` twice is a bad\r\nidea. I tested by actually running it twice, and... no crash/op? So\r\nseems safe? I'm hoping the CI run will be green, and this will be\r\nenough. However I'm happy to take feedback on how I should test this,\r\nand do the necessary changes.\r\n\r\n~Edit: looks like a test does fail, so moving to a draft while I figure\r\nthis out.~ Attempt 2 fixed it.","shortMessageHtmlLink":"fixes 12381, HttpClient socket handle leak (#23575)"}},{"before":"8a31b4735fa06619a041ef6dce5cbc497d4bb4b2","after":"f96a1aa86f62ab71fbb6fc85327a987a778cc48e","ref":"refs/heads/gh-pages","pushedAt":"2024-05-08T15:21:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy to GitHub pages","shortMessageHtmlLink":"Deploy to GitHub pages"}},{"before":"1ad4e80060f22275b2f443bd8630e2573619e487","after":"e662043fd1c43e8447fb7c30e97823f7d0a46a83","ref":"refs/heads/devel","pushedAt":"2024-05-08T15:11:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"rework `wasMoved`, `move` on the JS backend (#23577)\n\n`reset`, `wasMoved` and `move` doesn't support primitive types, which\r\ngenerate `null` for these types. It is now produce `x = default(...)` in\r\nthe backend. Ideally it should be done by ast2ir in the future","shortMessageHtmlLink":"rework wasMoved, move on the JS backend (#23577)"}},{"before":"7aa5616d936bcc8659074e182a5b2045d7810d08","after":null,"ref":"refs/heads/pr_js_reset","pushedAt":"2024-05-08T15:11:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"}},{"before":"81eb814eaa7fe085a15b12e23a73fa68cd7693fa","after":null,"ref":"refs/heads/pr_test_case","pushedAt":"2024-05-08T15:10:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"}},{"before":"6cc783f7f363a4cecd390563ca4fa1780c9af9d1","after":"1ad4e80060f22275b2f443bd8630e2573619e487","ref":"refs/heads/devel","pushedAt":"2024-05-08T15:10:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"fixes #22409; don't check style for enumFieldSymChoice in the function (#23580)\n\nfixes #22409","shortMessageHtmlLink":"fixes #22409; don't check style for enumFieldSymChoice in the function ("}},{"before":"3b4078a7f8a3bfd4f0047ed0b843e5485b08ffde","after":"6cc783f7f363a4cecd390563ca4fa1780c9af9d1","ref":"refs/heads/devel","pushedAt":"2024-05-08T15:07:33.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"fixes #23442, fix for FileId under Windows (#23444)\n\nSee according issue:\r\n\r\nDetails:\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>\r\nCo-authored-by: Andreas Rumpf ","shortMessageHtmlLink":"fixes #23442, fix for FileId under Windows (#23444)"}},{"before":null,"after":"3dd0aa4159dea5a45d905501988253e55c57ddbc","ref":"refs/heads/pr_enum_unorder","pushedAt":"2024-05-08T14:54:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"unordered enum","shortMessageHtmlLink":"unordered enum"}},{"before":"34507cef26f0daf18f6dd19370d0629856ed1201","after":"7aa5616d936bcc8659074e182a5b2045d7810d08","ref":"refs/heads/pr_js_reset","pushedAt":"2024-05-08T11:20:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"remove `mReset`","shortMessageHtmlLink":"remove mReset"}},{"before":"4d22e30127f94e560ba3964824fe8107c14a7a51","after":"8a31b4735fa06619a041ef6dce5cbc497d4bb4b2","ref":"refs/heads/gh-pages","pushedAt":"2024-05-07T21:13:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy to GitHub pages","shortMessageHtmlLink":"Deploy to GitHub pages"}},{"before":"78d70d5fdf68fff8345b80ddc6419d5fbe8bd877","after":"3b4078a7f8a3bfd4f0047ed0b843e5485b08ffde","ref":"refs/heads/devel","pushedAt":"2024-05-07T21:03:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"Araq","name":"Andreas Rumpf","path":"/Araq","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/287816?s=80&v=4"},"commit":{"message":"Skips generic owner when mangling instances (#23563)","shortMessageHtmlLink":"Skips generic owner when mangling instances (#23563)"}},{"before":"5093520500b9e3b9098bddbd9a339bd0db601e82","after":"81eb814eaa7fe085a15b12e23a73fa68cd7693fa","ref":"refs/heads/pr_test_case","pushedAt":"2024-05-07T14:57:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"a fix","shortMessageHtmlLink":"a fix"}},{"before":null,"after":"5093520500b9e3b9098bddbd9a339bd0db601e82","ref":"refs/heads/pr_test_case","pushedAt":"2024-05-07T14:55:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"fixes","shortMessageHtmlLink":"fixes"}},{"before":"007a306fe22e72ba8f9d88922e8a045516cb4c75","after":null,"ref":"refs/heads/revert-23566-ringabout-patch-5","pushedAt":"2024-05-07T11:13:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"}},{"before":"1ef4d04a1e56f67d85559a7964e9467df06bc2d7","after":"78d70d5fdf68fff8345b80ddc6419d5fbe8bd877","ref":"refs/heads/devel","pushedAt":"2024-05-07T11:13:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"bring `telebot` back (#23578)\n\nReverts nim-lang/Nim#23566\r\nref\r\nhttps://github.com/ba0f3/telebot.nim/commit/afe4ad877ec015091f5b6fde32ecb2502fe59a3f","shortMessageHtmlLink":"bring telebot back (#23578)"}},{"before":null,"after":"007a306fe22e72ba8f9d88922e8a045516cb4c75","ref":"refs/heads/revert-23566-ringabout-patch-5","pushedAt":"2024-05-06T14:42:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"Revert \"fixes CI failure (#23566)\"\n\nThis reverts commit 1ef4d04a1e56f67d85559a7964e9467df06bc2d7.","shortMessageHtmlLink":"Revert \"fixes CI failure (#23566)\""}},{"before":null,"after":"34507cef26f0daf18f6dd19370d0629856ed1201","ref":"refs/heads/pr_js_reset","pushedAt":"2024-05-06T14:37:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"rework `reset`, `move` on the JS backend","shortMessageHtmlLink":"rework reset, move on the JS backend"}},{"before":"36bf3fa47b81e1670bb82df5cc7e22334a9dbc32","after":"1ef4d04a1e56f67d85559a7964e9467df06bc2d7","ref":"refs/heads/devel","pushedAt":"2024-05-04T01:41:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"fixes CI failure (#23566)","shortMessageHtmlLink":"fixes CI failure (#23566)"}},{"before":"501fce9d3232c7db4463004c6185a8dde03bda0e","after":null,"ref":"refs/heads/ringabout-patch-5","pushedAt":"2024-05-04T01:41:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"}},{"before":"fcb8461efab2ef7bdd976f82af8c7d1390f502ac","after":"526e48b2ed2ee3e9dad9d61c1f3a96444225ebc4","ref":"refs/heads/version-2-0","pushedAt":"2024-05-03T14:45:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"narimiran","name":"Miran","path":"/narimiran","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16516130?s=80&v=4"},"commit":{"message":"handle the weirdness of the type of the `type` keyword","shortMessageHtmlLink":"handle the weirdness of the type of the type keyword"}},{"before":"90839c2c55201aefe69aff5ccefb2ab50a3a99a3","after":"4d22e30127f94e560ba3964824fe8107c14a7a51","ref":"refs/heads/gh-pages","pushedAt":"2024-05-03T14:39:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Deploy to GitHub pages","shortMessageHtmlLink":"Deploy to GitHub pages"}},{"before":null,"after":"501fce9d3232c7db4463004c6185a8dde03bda0e","ref":"refs/heads/ringabout-patch-5","pushedAt":"2024-05-03T14:31:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ringabout","name":"ringabout","path":"/ringabout","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/43030857?s=80&v=4"},"commit":{"message":"fixes CI failure","shortMessageHtmlLink":"fixes CI failure"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERQpTeAA","startCursor":null,"endCursor":null}},"title":"Activity · nim-lang/Nim"}