Commits on Oct 16, 2020

  1. cosmetic fixes for the 1.4 changelog [ci skip]

    (cherry picked from commit 6b8baab)
    narimiran committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    bdcd87a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. bump NimVersion to 1.4.1

    narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    1dffa67 View commit details
    Browse the repository at this point in the history
  2. fixes #15560 (#15587)

    (cherry picked from commit a43202e)
    Araq authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    b3c77bb View commit details
    Browse the repository at this point in the history
  3. Fix #15599 (#15601)

    * Fix #15599
    
    * Add test
    
    (cherry picked from commit 66cd9c2)
    Clyybber authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    d86d7c9 View commit details
    Browse the repository at this point in the history
  4. document that Nim executable must be included (#15611)

    (cherry picked from commit b16b2eb)
    n5m authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a222aa1 View commit details
    Browse the repository at this point in the history
  5. Fix FreeBSD build failures (#15613)

    The FreeBSD is/was failing, due to a conflict with installing Git.
    
    Git is guaranteed to be in the base image, so this removes that package from the package list. It also reverts back to the built-in `packages` tag since it's officially supported.
    
    Should the build fail in the future, the best place to go is the #sr.ht channel on freenode.
    
    (cherry picked from commit ba2a477)
    euantorano authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8a9da2f View commit details
    Browse the repository at this point in the history
  6. add tests for #15584 (#15619)

    * add test for #15584
    
    * Rename userlocks.nim to trlocks.nim
    
    * add bug comment
    
    * improve cmd
    
    * reference bugfix, not bug
    
    * add test that runs rlocks
    
    * disallow joining
    
    joining with other test cases (e.g., a test case that invokes `RLock.initRLock()`) may cause this test to compile, when the goal is to test if these lines can be compiled in isolation
    
    (cherry picked from commit 78cbb52)
    n5m authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    642807d View commit details
    Browse the repository at this point in the history
  7. Tables, use sink val arguments more actively (#15625)

    (cherry picked from commit 04f8fcf)
    cooldome authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    35f5a3e View commit details
    Browse the repository at this point in the history
  8. arc allocation method aligned (#15588)

    * progress
    
    * fix typo
    
    (cherry picked from commit 833035b)
    cooldome authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    1e9746a View commit details
    Browse the repository at this point in the history
  9. Fix #15639 (#15640)

    (cherry picked from commit 0f4b1ed)
    Clyybber authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    893dab4 View commit details
    Browse the repository at this point in the history
  10. fix #15631 (#15632)

    * trigger valgrind failure on memory leak
    
    * remove non-malloc tests
    
    * remove ORC test
    
    is redundant because we already have an ARC test
    
    * only run valgrind tests on 64-bit Linux
    
    * disable freebsd and openbsd
    
    * Remove tleak_refc
    
    As to not test implementation details (or bug)
    
    * Fix test failures by removing redundant test
    
    Since this tests/shoulfail/tvalgrind.nim was specified here to fail this test
    itself fails since it will be skipped on non-linux CI
    
    * Remove test, reason detailed in the previous commit
    
    * Remove redundant disables
    
    * Revert removing disables
    
    * Add and use valgrind: leaks
    
    * Fix
    
    Co-authored-by: Clyybber <darkmine956@gmail.com>
    Co-authored-by: n5m
    (cherry picked from commit 436e1fa)
    2 people authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    1d63995 View commit details
    Browse the repository at this point in the history
  11. Fix commentOffsetA for doc comments (#15643)

    (cherry picked from commit f20e485)
    Clyybber authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    45977c2 View commit details
    Browse the repository at this point in the history
  12. it is not "eg", it is "e.g."

    (cherry picked from commit 0a68665)
    narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    c087e2d View commit details
    Browse the repository at this point in the history
  13. more "eg" fixes

    (cherry picked from commit 5e9dd81)
    narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8fb501b View commit details
    Browse the repository at this point in the history
  14. Remove bit about opening files not raising (#15654)

    Resolved #473
    
    I am removing this bit because this advice to not throw on recoverable-from cases like a file failing to open is actually not respected by Nim standard library. `readFile` and `readLines` both throw and exceptions must be used as a method of control flow for the recovery from that. There are alternatives, like opening a file handle instead of using these helpers, but that's less convenient than these helper methods for cases where you really want to just slurp up a file to memory and use a fallback value if it doesn't exist or is for whatever reason not readable.
    
    (cherry picked from commit 725c7ca)
    TomasHubelbauer authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    293ef09 View commit details
    Browse the repository at this point in the history
  15. even more "eg" fixes [ci skip]

    (cherry picked from commit b418c54)
    narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    38ebd76 View commit details
    Browse the repository at this point in the history
  16. Fix compilation error for regions and memory profiling (#15641) (#15656)

    Co-authored-by: Recruit_main707 <Recruit_main707@users.noreply.github.com>
    (cherry picked from commit ed0f8a4)
    2 people authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    5874bce View commit details
    Browse the repository at this point in the history
  17. $(uint|uint64) now works with nimscript (#15644)

    * $(uint|uint64) now works with nimscript
    
    * fixup
    
    (cherry picked from commit 3cbe8d2)
    timotheecour authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    11ef97d View commit details
    Browse the repository at this point in the history
  18. fixes bootstrapping for any machine that has a Nim already installed …

    …[backport:1.4] (#15660)
    
    (cherry picked from commit 9a05965)
    Araq authored and narimiran committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    eb04535 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Fix #13609 (#15567)

    * add documentation that discardable pragma cannot use on template
    
    * Update doc/manual.rst
    
    Co-authored-by: Euan <euantorano@users.noreply.github.com>
    
    * Update doc/manual.rst
    
    Co-authored-by: Euan <euantorano@users.noreply.github.com>
    
    Co-authored-by: Euan <euantorano@users.noreply.github.com>
    (cherry picked from commit b2f51e2)
    2 people authored and narimiran committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    bc5c6c8 View commit details
    Browse the repository at this point in the history
  2. expect valgrind test failure on memory leak (#15669)

    * expect valgrind test failure on memory leak
    
    * alloc 1 instead of 0
    
    (cherry picked from commit 8da0e01)
    n5m authored and narimiran committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    06846d2 View commit details
    Browse the repository at this point in the history
  3. [backport: 1.4] Better linebreaks (#15658)

    (cherry picked from commit d8a6b0b)
    narimiran committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    6d99de7 View commit details
    Browse the repository at this point in the history
  4. fixes #15652 [backport:1.4] (#15679)

    (cherry picked from commit 8358974)
    Araq authored and narimiran committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    ce94ce4 View commit details
    Browse the repository at this point in the history
  5. fixes view types for sizeof() and --gc:orc (#15680)

    (cherry picked from commit 64016dd)
    Araq authored and narimiran committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    e7b7356 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Fix #12410 (#15685)

    * Fix #12410, big thanks to @pmetras for this fix
    
    * Add testcase
    
    (cherry picked from commit 01a6232)
    Clyybber authored and narimiran committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    7a9db0e View commit details
    Browse the repository at this point in the history
  2. fix #15662 (#15678)

    * fix #15662
    
    * alternative fix
    
    * fix spacing
    
    (cherry picked from commit ae320b4)
    cooldome authored and narimiran committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    d1924f2 View commit details
    Browse the repository at this point in the history
  3. Revert "fixes #15280 [backport:1.2] (#15281)" (#15700)

    This reverts commit 3f00a73.
    
    (cherry picked from commit d4022eb)
    Clyybber authored and narimiran committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    9e8ad86 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Try to fix CI failures (#15701)

    * Use cligens release version
    
    * Rework important_packages main loop
    
    * Fix
    
    * Fix
    
    * Create pkgs dir
    
    * Don't use nimble develop
    since it doesn't work for binary only packages, and always install head
    
    * Use git to get the latest release/tag instead
    
    * Tackle the root cause
    
    * Reduce diff
    
    * Cleanup
    
    (cherry picked from commit e18fc69)
    Clyybber authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    9b37fc9 View commit details
    Browse the repository at this point in the history
  2. [minor] nimVMDebug: fix codeListing formatting for jump-to-file to wo…

    …rk (#15711)
    
    (cherry picked from commit 64eb628)
    timotheecour authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    e895927 View commit details
    Browse the repository at this point in the history
  3. fix #15698 (#15699)

    * fix in the net.`$` to print zeros that are not in the compressed group
    
    * Update lib/pure/net.nim
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    
    * Update net.nim
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit 7252a50)
    2 people authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    796785a View commit details
    Browse the repository at this point in the history
  4. Fix Prelude (#15714)

    * ReSync with Devel
    
    * Fix prelude for JS target
    
    * ReSync devel
    
    * Fix prelude for JS target
    
    (cherry picked from commit e284445)
    juancarlospaco authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a48c16b View commit details
    Browse the repository at this point in the history
  5. Add tests to #15363 (#15633)

    (cherry picked from commit d22ab0f)
    Danil Yarantsev authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    60ddbf1 View commit details
    Browse the repository at this point in the history
  6. close #8007 (#15695)

    (cherry picked from commit bf894ad)
    timotheecour authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    9d81415 View commit details
    Browse the repository at this point in the history
  7. fix #15704 #15597 wrong VM register was freed (#15705)

    * fix #15704 #15597 wrong VM register was freed
    
    * same treatment for nkCheckedFieldExpr
    
    * note concerning HighRegisterPressure
    
    * bump NimPatch
    
    * Update lib/system.nim
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit d4c2e2c)
    2 people authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    4e91c11 View commit details
    Browse the repository at this point in the history
  8. Add support to the latest LibreSSL version (#15715) [backport:1.2] [b…

    …ackport:1.4]
    
    (cherry picked from commit b2740f5)
    Danil Yarantsev authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a2367d4 View commit details
    Browse the repository at this point in the history
  9. Fixed iteration limit hit from execproc (#15723) [backport:1.2] [back…

    …port:1.4]
    
    When calling procs from Nim in Nimscript you could hit the VM iteration limit even though the code is functioning properly. This resolves that by making the iteration limit reset eachtime you call a proc.
    
    (cherry picked from commit a876179)
    beef331 authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2351b66 View commit details
    Browse the repository at this point in the history
  10. add criterion to important packages (#15604)

    * add criterion to important packages
    
    * use a special nimscript for criterion tests
    
    * fix criterion speed differently
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit ea6c282)
    2 people authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    75d76c2 View commit details
    Browse the repository at this point in the history
  11. Copy editing (#15733)

    (cherry picked from commit ae8eb1e)
    drkameleon authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    513ced8 View commit details
    Browse the repository at this point in the history
  12. Documentation only iup (#15732)

    * ReSync with Devel
    
    * ReSync
    
    * Add Examples for IUP, based from official doc
    
    (cherry picked from commit 3a69f14)
    juancarlospaco authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    c8f6eb6 View commit details
    Browse the repository at this point in the history
  13. ensure the Nim compiler works with --experimental:strictFuncs --exper…

    …imental:views [backport:1.4] (#15737)
    
    (cherry picked from commit cf01945)
    Araq authored and narimiran committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a156484 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. [backport] fix #15595 procvar == works in VM (#15724)

    (cherry picked from commit 3bdc000)
    timotheecour authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    3326f1d View commit details
    Browse the repository at this point in the history
  2. Document implicit return values from procedures (#15738)

    (cherry picked from commit 2595544)
    fxn authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    1fbfd77 View commit details
    Browse the repository at this point in the history
  3. add tests for Testament "reject" action (#15709)

    * add test for reject action
    
    * highlight that a compilation failure is expected
    
    * add the converse test for action=reject
    
    * add trailing newline
    
    * fix wording
    
    (cherry picked from commit 066f3eb)
    n5m authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    33375af View commit details
    Browse the repository at this point in the history
  4. fixes #10456,#12928 issues when chaining templates to sortedByIt (#15734

    )
    
    * update c_malloc's to csize_t
    
    fix for broken --os:ios
    
    * I'm an idiot sorry
    
    * Create talgorithm.nim
    
    * workaround for #10456
    
    I don't understand the intricacies of how lambdalifting and template expansions interact with lent, so i don't know how to fix the real problem, but this sidesteps whatever issue that is.
    
    * working test, use typeof rather than auto
    
    (cherry picked from commit 218acfe)
    shirleyquirk authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    5c48058 View commit details
    Browse the repository at this point in the history
  5. fix #15752 (#15754)

    (cherry picked from commit f8cac6b)
    cooldome authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    afb5212 View commit details
    Browse the repository at this point in the history
  6. fix #15750

    (cherry picked from commit b13fb9d)
    narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    96bd642 View commit details
    Browse the repository at this point in the history
  7. change/remove deprecated stuff

    (cherry picked from commit 732ddc0)
    narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    e27f595 View commit details
    Browse the repository at this point in the history
  8. ARC now capable of custom extra alignment. Ref, closure and seq suppo…

    …rt. (#15697)
    
    (cherry picked from commit 0956a99)
    cooldome authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    a4f9bc5 View commit details
    Browse the repository at this point in the history
  9. fix #15756 (#15761)

    * fix #15756
    
    * simplify test
    
    (cherry picked from commit 610e9b2)
    cooldome authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    e39b01e View commit details
    Browse the repository at this point in the history
  10. Make newObjUninit proc to adhere to its name (#15764)

    Co-authored-by: b3liever <b3liever@yandex.com>
    (cherry picked from commit 94e2b9e)
    2 people authored and narimiran committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    60403c9 View commit details
    Browse the repository at this point in the history