Commits on Jul 3, 2023

  1. bump NimVersion to 1.6.15

    narimiran committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d1b5df0 View commit details
    Browse the repository at this point in the history
  2. fix controlflow test (#22194)

    the function actually returns
    
    (cherry picked from commit 4d2ebbb)
    arnetheduck authored and narimiran committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bb56a37 View commit details
    Browse the repository at this point in the history
  3. fix new type inference for noreturn [backport] (#22182)

    fixes #22180
    
    Backported since apparently the new type inference was backported
    
    (cherry picked from commit b35942e)
    metagn authored and narimiran committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    1cd48e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. fixes AddressSanitizer: global-buffer-overflow in getAppFilename on w…

    …indows 10 (#22380)
    
    fixes AddressSanitizer: global-buffer-overflow
    
    (cherry picked from commit 73a29d7)
    norrath-hero-cn authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0cb8472 View commit details
    Browse the repository at this point in the history
  2. fixes #22387; Undefined behavior when with hash(...) (#22404)

    * fixes #22387; Undefined behavior when with hash(...)
    
    * fixes vm
    
    * fixes nimscript
    
    (cherry picked from commit 47d06d3)
    ringabout authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b901e94 View commit details
    Browse the repository at this point in the history
  3. fixes #22419; async/closure environment does not align local variables (

    #22425)
    
    * fixes #22419; async/closure environment does not align local variables
    
    * Apply suggestions from code review
    
    * Update tests/align/talign.nim
    
    Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
    
    * apply code review
    
    * update tests
    
    ---------
    
    Co-authored-by: Jacek Sieka <arnetheduck@gmail.com>
    (cherry picked from commit 5334dc9)
    2 people authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bd4609f View commit details
    Browse the repository at this point in the history
  4. use unsafeAddr

    narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    80ece59 View commit details
    Browse the repository at this point in the history
  5. fixes #22208; Ambiguous error when import modules with same names but… (

    #22211)
    
    fixes #22208; Ambiguous error when import modules with same names but different aliases
    
    (cherry picked from commit d9a24b9)
    ringabout authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    01ef1e1 View commit details
    Browse the repository at this point in the history
  6. fixes #20516; system.create doesn't work with bitfield objects (#20518)

    * Revert "fixes #19000 (#19032)"
    
    This reverts commit 2bda4a3.
    
    * fixes #20516; add testcase
    
    (cherry picked from commit 5e4dd57)
    ringabout authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5d39a82 View commit details
    Browse the repository at this point in the history
  7. Delete parse directory, which was pushed wrongly before [backport] (#…

    …22401)
    
    Delete parse directory
    
    (cherry picked from commit 614a18c)
    ringabout authored and narimiran committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a2521b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. static link pthread correctly (#21693)

    (cherry picked from commit f947739)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    58c7474 View commit details
    Browse the repository at this point in the history
  2. fix iterator equality + add test for proc equality + fix sameType (#2…

    …1707)
    
    * fix iterator equality + add test also for procs
    
    fixes #21706
    
    * all targets
    
    * and isNil and repr
    
    * separate overloads, fix sameType
    
    * more restricted sameType?
    
    * merge overloads again??
    
    * remove sametype change for now
    
    * fix sameType anyway (CI failure was not related)
    
    ---------
    
    Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
    (cherry picked from commit 380dafc)
    2 people authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7b99712 View commit details
    Browse the repository at this point in the history
  3. fixes #21703; moveOrCopy should consider when vm (#21721)

    (cherry picked from commit 0f226c0)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    579efda View commit details
    Browse the repository at this point in the history
  4. cheap fix for #10853 + better tuple subscript error message (#21767)

    * cheap fix for #10853
    
    * also better tuple subscript error message
    
    * weird
    
    (cherry picked from commit c2bcfd8)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    cd0f805 View commit details
    Browse the repository at this point in the history
  5. line info for strformat + fix issue with typed templates (#21761)

    * line info in strformat
    
    * also fix #20381
    
    (cherry picked from commit e5d0907)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fa3639b View commit details
    Browse the repository at this point in the history
  6. error on user pragma args (#21776)

    closes #20978
    
    (cherry picked from commit 44736d2)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    547f205 View commit details
    Browse the repository at this point in the history
  7. fixes #21792; enable checks for sum, prod, cumsummed and cumsum (#21793)

    * enable checks for sum, prod, cumsummed  and cumsum
    
    * fixes #21792
    
    * add test cases
    
    (cherry picked from commit 07233ce)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    7a747fe View commit details
    Browse the repository at this point in the history
  8. 🚀 Enhancing CellSeq for Better Readability and Maintainability (#21797)

    Refactor and improve readability of CellSeq in system directory
    
    * Use half-open range in the contains procedure for better readability and to avoid potential off-by-one errors
    * Extract resizing logic from add procedure into a separate resize procedure for better code readability and separation of concerns
    
    (cherry picked from commit 71f2e1a)
    jordan-gillard authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a9f1e2d View commit details
    Browse the repository at this point in the history
  9. Improve and refactor cellseqs_v2 in Nim standard library (#21796)

    * Refactor and optimize cellseqs_v2 in Nim standard library
    
    * Extract resizing logic into a separate 'resize' procedure for better readability and separation of concerns
    * Implement realloc for non-threaded cases to improve memory operations efficiency
    * Use ',' instead of ';' between parameters in 'add' procedure for consistency with other Nim code
    
    * Respond to Araq's feedback: Refactor resize function to use reallocShared
    
    This commit replaces the usage of allocShared and deallocShared with reallocShared to optimize memory allocation and deallocation while resizing the CellSeq.
    
    (cherry picked from commit b169dad)
    jordan-gillard authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1cca8cc View commit details
    Browse the repository at this point in the history
  10. Add nnkHiddenCallConv to nnkCallKinds (#21781) (#21829)

    (cherry picked from commit 802d57c)
    mattdw authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2d19520 View commit details
    Browse the repository at this point in the history
  11. cursor fields cannot form reference cycles (#21832)

    * cursor fields cannot form a reference cycle
    
    * fixes typo
    
    * fixes position
    
    (cherry picked from commit ebbad9e)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    fcaacbf View commit details
    Browse the repository at this point in the history
  12. just set CallNodes = nnkCallKinds, follows up #21829 (#21833)

    These sets are now equal
    
    (cherry picked from commit 9810b8c)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6fbff26 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    09fe696 View commit details
    Browse the repository at this point in the history
  14. Fixed generic parameters failing to be used in inheritance (#21866)

    (cherry picked from commit 28a116a)
    beef331 authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c438010 View commit details
    Browse the repository at this point in the history
  15. fix #21251 Compiler SIGSEGV when using SharedTable (#21876)

    fix #21251
    
    (cherry picked from commit 76a98fe)
    bung87 authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    173a15b View commit details
    Browse the repository at this point in the history
  16. fixes #15428 by updating deep open array copy codegen (#21935)

    * fix #15428
    
    * add test
    
    (cherry picked from commit af3fd5a)
    heterodoxic authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6b11a9e View commit details
    Browse the repository at this point in the history
  17. Improve compiler messages (#22028)

    * Improve compiler messages with simpler code
    
    (cherry picked from commit 9f3d1b1)
    juancarlospaco authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e4c13c3 View commit details
    Browse the repository at this point in the history
  18. Improve compiler messages (#22040)

    * Improve compiler messages
    
    (cherry picked from commit ea91cfb)
    juancarlospaco authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c001b11 View commit details
    Browse the repository at this point in the history
  19. clean up isNilConversion for seqs, strings (#22057)

    (cherry picked from commit 49e11d9)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ffcccd5 View commit details
    Browse the repository at this point in the history
  20. consider object types as declarative in templates (#22106)

    * consider object types as declarative in templates
    
    fixes #16005
    
    * correct logic for nkRecList children, inject fields
    
    * don't actually inject fields
    
    (cherry picked from commit 3ac2d81)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    107ec62 View commit details
    Browse the repository at this point in the history
  21. fixes #22049; fixes #22054; implicit conversion keeps varness (#22097)

    * fixes #22054; codegen for var tuples conv
    
    * rethink fixes
    
    * add test cases
    
    * templates only
    
    * fixes var tuples
    
    * keep varness no matter what
    
    * fixes typ.isNil
    
    * make it work for generics
    
    * restore isSubrange
    
    * add a test case as requested
    
    (cherry picked from commit 77beb15)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    070ecb0 View commit details
    Browse the repository at this point in the history
  22. fixes #16331; aliasing of tuple construction within a single assignme… (

    #22113)
    
    * fixes #16331; aliasing of tuple construction within a single assignment, great coding style
    
    * added test case
    
    (cherry picked from commit e8d0f1c)
    Araq authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9d573f4 View commit details
    Browse the repository at this point in the history
  23. strutils.split/rsplit now return src on an empty sep (#22136)

    This is a rebase of an earlier rejected PR. Following the discussion
    around it, this commit provides a valid output for and edge case
    of an empty separator for `split` and `rsplit` routines. The empty
    separator is interpreted as "split by no separators" and the initial
    string is returned. This is consistent with the behaviour of the
    `set[char]` version of `split`/`rsplit` routines and unifies them all.
    
    Compared to a commit merged earlier, this one has a benefit of
    not using assertions that will be removed in release builds
    and thus still not preventing possible infinite loops (which was the
    earlier behaviour for this edge case for separator of type `string`).
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit 5e529b3)
    2 people authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6863b5d View commit details
    Browse the repository at this point in the history
  24. fix #20023 hash for generic tables (#20346)

    * fix #20023 hash for generic tables
    
    * use default computation
    
    * Update lib/pure/collections/tables.nim
    
    Co-authored-by: Dan Rose <dan@digilabs.io>
    
    * Update lib/pure/collections/tables.nim
    
    Co-authored-by: Dan Rose <dan@digilabs.io>
    
    * Update lib/pure/collections/tables.nim
    
    * Update lib/pure/collections/tables.nim
    
    * Update t20023.nim
    
    ---------
    
    Co-authored-by: Dan Rose <dan@digilabs.io>
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit 3ad2e7d)
    3 people authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a66158d View commit details
    Browse the repository at this point in the history
  25. fixes #21231; template with module as parameter elides usage/checking…

    … of module name specifier (#22109)
    
    * fixes #21231; template with module as parameter elides usage/checking of module name specifier
    
    * add a test case
    
    (cherry picked from commit ac7b8b6)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    238efc0 View commit details
    Browse the repository at this point in the history
  26. fixes #21110; duplicate proc definitions for inline iters (#21136)

    fixes #21110; duplicate proc definitions for iters
    
    (cherry picked from commit 8811494)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3bd03d7 View commit details
    Browse the repository at this point in the history
  27. make var object match better than object (#22152)

    * fix `var object` not matching better than `object`
    
    fixes #13302
    
    * remove comment for brevity
    
    * try note
    
    * try minimize breaks
    
    (cherry picked from commit 20037a4)
    metagn authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5e46482 View commit details
    Browse the repository at this point in the history
  28. uint arithmetic for pointers (#22159)

    pointers are not signed and arithmetic may correctly cross int.max
    threshold
    
    this PR only fixes 2 occurances - there are plenty however in the std
    lib
    
    (cherry picked from commit cb40f11)
    arnetheduck authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b0cee7c View commit details
    Browse the repository at this point in the history
  29. fix Sigaction struct definition (#22160)

    SigInfo is still wrong (most of its fields are in a union)
    
    (cherry picked from commit 47635d3)
    arnetheduck authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5ab9945 View commit details
    Browse the repository at this point in the history
  30. fixes #22137 (#22170)

    (cherry picked from commit ce0909f)
    Araq authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    322fc31 View commit details
    Browse the repository at this point in the history
  31. Fix nimsuggest not showing suggestions for imported tuples (#22241)

    * Add tests
    
    Also test if exported all tuple fields works. This seems like a hacky solution so will try and dive further to find a better solution
    
    * Always suggest tuple fields if it passes the filter
    
    If the tuple we are accessing is in scope then all the fields will also be in scope
    
    * Update tests so line numbers are correct
    
    (cherry picked from commit 1b132dd)
    ire4ever1190 authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5ffd507 View commit details
    Browse the repository at this point in the history
  32. fix wrong import

    narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0e92502 View commit details
    Browse the repository at this point in the history
  33. fixes #22237; fixes #21160; wrong cursor on unowned parameters in the…

    … for loop in ORC (#22240)
    
    fixes #22237; fixes #21160; wrong cursor on unowned parameters
    
    (cherry picked from commit ecc6ab7)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    44708f4 View commit details
    Browse the repository at this point in the history
  34. gendepends now supports pkgs2 (#22277)

    (cherry picked from commit 3b37793)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e7fc94e View commit details
    Browse the repository at this point in the history
  35. Fix #22281 (#22289)

    Respect `--gcc.exe` and similar options when `--genScript:on` is used.
    
    (cherry picked from commit 14a9929)
    CyberTailor authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0ac3461 View commit details
    Browse the repository at this point in the history
  36. fixes #22297; return in the finally in the closure iterators (#22300)

    ref #22297; return in the finally in the closure iterators
    
    (cherry picked from commit b02c1dd)
    ringabout authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ba2d8ba View commit details
    Browse the repository at this point in the history
  37. Open scope for defer (#22315)

    Co-authored-by: SirOlaf <>
    (cherry picked from commit 3ebe249)
    SirOlaf authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a3b65da View commit details
    Browse the repository at this point in the history
  38. Check try block for endsInNoReturn (#22314)

    Co-authored-by: SirOlaf <>
    (cherry picked from commit 62869a5)
    SirOlaf authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    30921aa View commit details
    Browse the repository at this point in the history
  39. Remove declared and not used variable in packedsets.bitincl (#22334)

    When compiling code that uses PackedSet with warnings enabled, `var ret`
    in `bitincl` emits a "XDeclaredButNotUsed" warning.
    
    (cherry picked from commit f1ac979)
    ericvw authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    72afd29 View commit details
    Browse the repository at this point in the history
  40. Fix crash when using uninstantiated generic (#22379)

    * Add test case
    
    * Add in a bounds check when accessing generic types
    
    Removes idnex out of bounds exception when comparing a generic that isn't fully instantiated
    
    (cherry picked from commit 3efabd3)
    ire4ever1190 authored and narimiran committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    118f83f View commit details
    Browse the repository at this point in the history