Commits on Feb 23, 2022

  1. bump NimVersion to 1.6.5

    narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    231a135 View commit details
    Browse the repository at this point in the history
  2. Making TCC work again on Windows --cpu:amd64 - fix #16326 (#19221)

    * fix #16326
    
    * removing comments
    
    (cherry picked from commit 7806ec5)
    rockcavera authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    8fe8aad View commit details
    Browse the repository at this point in the history
  3. Fix #19038 - making the Nim compiler work again on Windows XP (#19331)

    * Update osenv.nim
    
    * Update win_setenv.nim
    
    * Update lib/pure/includes/osenv.nim
    
    * Update lib/pure/includes/osenv.nim
    
    * fixing cstring
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit c7d5b8c)
    2 people authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    c25b7e7 View commit details
    Browse the repository at this point in the history
  4. fix 19292 (#19293)

    (cherry picked from commit 77ad8b8)
    rockcavera authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    82c930c View commit details
    Browse the repository at this point in the history
  5. Fix #19038 - making the Nim compiler work again on Windows XP (#19331)

    * Update osenv.nim
    
    * Update win_setenv.nim
    
    * Update lib/pure/includes/osenv.nim
    
    * Update lib/pure/includes/osenv.nim
    
    * fixing cstring
    
    Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
    (cherry picked from commit c7d5b8c)
    2 people authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    9746d46 View commit details
    Browse the repository at this point in the history
  6. Merge pull request from GHSA-ggrq-h43f-3w7m

    This fixes a CVE (currently
    GHSA-ggrq-h43f-3w7m)
    
    (cherry picked from commit cb894c7)
    dom96 authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    b6024fe View commit details
    Browse the repository at this point in the history
  7. undefine C symbols in JS backend [backport:1.6] (#19437)

    fix #19330; fix #19059
    
    (cherry picked from commit 7b09fd7)
    ringabout authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    5e13d57 View commit details
    Browse the repository at this point in the history
  8. setjump => setjmp [backport: 1.2] (#19496)

    (cherry picked from commit d028774)
    ringabout authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    971b639 View commit details
    Browse the repository at this point in the history
  9. fix broken CI (#19472)

    * fix broken CI
    
    * fix
    
    * fix tests
    
    (cherry picked from commit 56a901f)
    ringabout authored and narimiran committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    d7370ce View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. Configuration menu
    Copy the full SHA
    b8f1347 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec9e51a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. compile pragma: cache the result sooner (#19554)

    extccomp.addExternalFileToCompile() relies on hashes to decide whether
    an external C file needs recompilation or not.
    
    Due to short-circuit evaluation of boolean expressions, the procedure
    that generates a corresponding hash file is not called the first time an
    external file is compiled, so an avoidable recompilation is triggered
    the next build.
    
    This patch fixes that by moving the proc call with a desired side
    effect from its boolean expression, so it's executed unconditionally.
    
    (cherry picked from commit 0c915b5)
    stefantalpalaru authored and narimiran committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    ebb140e View commit details
    Browse the repository at this point in the history
  2. fixes #19569 (#19595) [backport]

    * minor code refactorings
    
    * fixes #19569
    
    (cherry picked from commit 0d6795a)
    Araq authored and narimiran committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    0bb7bd0 View commit details
    Browse the repository at this point in the history
  3. fixes #19575 (#19596) [backport]

    * fixes #19575
    
    * better bugfix
    
    (cherry picked from commit 2beefb9)
    Araq authored and narimiran committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    2d25877 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. fixes #19631 (#19618)

    Aliasing is hard and we have to watch out not to compile 'x = f(x.a)' into 'f(x.a, addr x)'
    
    (cherry picked from commit 731eabc)
    Araq authored and narimiran committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    ff81975 View commit details
    Browse the repository at this point in the history
  2. fixes #19615; emit better code for integer divisions when the divisor… (

    #19626)
    
    * fixes #19615; emit better code for integer divisions when the divisor is known at compile-time
    
    * proper bugfix: unsigned numbers cannot be -1
    
    (cherry picked from commit c4a0d4c)
    Araq authored and narimiran committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    40db88d View commit details
    Browse the repository at this point in the history
  3. Fixed formatting error for warningAsError. (#19634)

    There was only a single space character between the warning and its description, so it shows up as part of the name (in bold) and with no description.
    Copied the way hotCodeReloading was formatted, with the description in a new line.
    yoyojambo authored Mar 22, 2022
    Configuration menu
    Copy the full SHA
    01c3861 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. output byref types into --header file [backport: 1.6] (#19505)

    * output byref types into --header file
    
    fix #19445
    
    * fix comments
    
    * set targets
    
    (cherry picked from commit 2c01c9c)
    ringabout authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9df55a8 View commit details
    Browse the repository at this point in the history
  2. fix nim check nimscript [backport: 1.6] (#19444)

    fix #19440; fix #3858
    
    (cherry picked from commit 7c3c61f)
    ringabout authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    b741f3c View commit details
    Browse the repository at this point in the history
  3. Add Zephyr Support (#19003)

    * Porting Nim to run on Zephyr.
    
    Includes changes to `std/net`.
    
    Squashed commit of the following:
        tweaking more memory / malloc things
        revert back bitmasks
        tweaking nim to use kernel heap as C malloc doesn't work
        fixing socket polling on zephyr
        cleanup getting maximum sockets for process or for rtos'es
        reorganizing and fixing net for async / system
        merge netlite changes back into nativesockets
        merge netlite changes back into nativesockets
        reverting native sockets back
        tweaking nim / zephyr network
        adding option to run 'net-lite' from linux
        bridging zephyr's max connections
        fixing net errors
        fixing compilation with getAddrString
        fixing compilation with getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ...
        add note regarding incorrect FreeRTOS Sockadd_in fields
        changing to NIM_STATIC_ASSERT
        cleaning up the static_assert error messages
        cleaning up the static_assert error messages
        setting up static assert ftw!
        testing compile time asserts
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        finding missing items (issue  #18684)
        fixup posix constants (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
    
    * fixing constant capitalizations
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * Porting Nim to run on Zephyr.
    
    Includes changes to `std/net`.
    
    Squashed commit of the following:
        tweaking more memory / malloc things
        revert back bitmasks
        tweaking nim to use kernel heap as C malloc doesn't work
        fixing socket polling on zephyr
        cleanup getting maximum sockets for process or for rtos'es
        reorganizing and fixing net for async / system
        merge netlite changes back into nativesockets
        merge netlite changes back into nativesockets
        reverting native sockets back
        tweaking nim / zephyr network
        adding option to run 'net-lite' from linux
        bridging zephyr's max connections
        fixing net errors
        fixing compilation with getAddrString
        fixing compilation with getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ...
        add note regarding incorrect FreeRTOS Sockadd_in fields
        changing to NIM_STATIC_ASSERT
        cleaning up the static_assert error messages
        cleaning up the static_assert error messages
        setting up static assert ftw!
        testing compile time asserts
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        finding missing items (issue  #18684)
        fixup posix constants (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
    
    * fixing constant capitalizations
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * fixing PR issues
    
    * Porting Nim to run on Zephyr.
    
    Includes changes to `std/net`.
    
    Squashed commit of the following:
        tweaking more memory / malloc things
        revert back bitmasks
        tweaking nim to use kernel heap as C malloc doesn't work
        fixing socket polling on zephyr
        cleanup getting maximum sockets for process or for rtos'es
        reorganizing and fixing net for async / system
        merge netlite changes back into nativesockets
        merge netlite changes back into nativesockets
        reverting native sockets back
        tweaking nim / zephyr network
        adding option to run 'net-lite' from linux
        bridging zephyr's max connections
        fixing net errors
        fixing compilation with getAddrString
        fixing compilation with getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getAddrString
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ... getLocalAddr
        experimenting with a nativesockets_lite ...
        add note regarding incorrect FreeRTOS Sockadd_in fields
        changing to NIM_STATIC_ASSERT
        cleaning up the static_assert error messages
        cleaning up the static_assert error messages
        setting up static assert ftw!
        testing compile time asserts
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        reworking Sockaddr objects to more closely match various platforms
        finding missing items (issue  #18684)
        fixup posix constants (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
        adding plumbing for zephyr os (issue  #18684)
    
    * fixing constant capitalizations
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * Remerge
    
    * fixing constant capitalizations
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * remove extra debug prints and fix TSa_Family/cint issue
    
    * fixing PR issues
    
    * fix maxDescriptors on zephyr/freertos
    
    * move maxDescriptors to selector.nim -- fixes compile issue
    
    * change realloc impl on zephyr to match ansi c behavior
    
    * change realloc impl on zephyr to match ansi c behavior
    
    * force compileOnly mode for tlwip
    
    Co-authored-by: Jaremy J. Creechley <jaremy.creechley@wavebaselabs.com>
    Co-authored-by: Jaremy Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit 141b76e)
    3 people authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1dc4769 View commit details
    Browse the repository at this point in the history
  4. Enable customizing PageShift to set PageSize for embedded targets (#1…

    …9129)
    
    * Enable customizing PageSize (via PageShift).
    
    This enables adjusting PageSize for embedded targets without abusing
    cpu16.
    
    * copy nimPageXYZ settings for mmpaptest
    
    * add docs for Nim manual
    
    * add docs for Nim manual
    
    * docs tweaks
    
    Co-authored-by: Jaremy Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit 92d6fb8)
    2 people authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    b9363c8 View commit details
    Browse the repository at this point in the history
  5. Implement zephyr urandom and monotime (#19142)

    * implement urandom for Zephyr
    
    * add monotime on zephyr
    
    Co-authored-by: Jaremy Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit 6976d18)
    2 people authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    8aa0458 View commit details
    Browse the repository at this point in the history
  6. Implement threads on Zephyr (#19156)

    * pthreads setup for zephyr
    
    - enable tweak stack size
    - update lib/system/threads.nim
    - Fix int/uint in casting pointer.
    
    * add documentation and tweak flag names
    
    * add documentation and tweak flag names
    
    * fix configuration flag names
    
    * fix configuration flag names
    
    * cleanup
    
    Co-authored-by: Jaremy Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit 7772ca3)
    2 people authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4877caa View commit details
    Browse the repository at this point in the history
  7. fix no net compilation on zephyr (#19399)

    Co-authored-by: Jaremy J. Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit dc8ac66)
    2 people authored and narimiran committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    9fcf1a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. mitigates #19364 [backport]; we make this bug more unlikely to appear…

    … by producing better code to begin with; real fix will come later (#19647)
    
    (cherry picked from commit 12a0f88)
    Araq authored and narimiran committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bf3a2e0 View commit details
    Browse the repository at this point in the history
  2. Fix dial ignoring buffered parameter (#19650) [backport]

    (cherry picked from commit 8cdd886)
    forsenonlhaimaisentito authored and narimiran committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    9b56074 View commit details
    Browse the repository at this point in the history
  3. fix #8219; nim check/dump shouldn't run single nimscript project [bac…

    …kport: 1.6] (#19641)
    
    * fix #8219; nim check/dump shouldn't run single nimscript project [backport: 1.6]
    
    (cherry picked from commit 82319ef)
    ringabout authored and narimiran committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    fd2da6d View commit details
    Browse the repository at this point in the history
  4. system: thread: stack dealloction on Zephyr (#19633) [backport:1.6]

    Try to free the stack allocation when a thread exits. Possibly works for FreeRTOS as well.
    
    (cherry picked from commit 4c89343)
    elcritch authored and narimiran committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0adfe6c View commit details
    Browse the repository at this point in the history
  5. Embedded Network patches - eventfd & socket getters (#19632)

    (cherry picked from commit eae29e8)
    elcritch authored and narimiran committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    589dc2d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. devel: style fix (#19318)

    this allows "--styleCheck:usages --styleCheck:error"
    
    (cherry picked from commit 35cae73)
    stefantalpalaru authored and narimiran committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9de1013 View commit details
    Browse the repository at this point in the history
  2. Various std net improvements (#19132)

    * Variant of  that works with raw IpAddresses.
    
    - Add doc tests for new net proc's.
    - Aadd recvFrom impl
    - Add recvFrom impl -- tweak handling data var
    
    - Update lib/pure/net.nim
    	Co-authored-by: Dominik Picheta <dominikpicheta@googlemail.com>
    
    - cleaning up sendTo args
    - remove extra connect test
    - cleaning up sendTo args
    - fix inet_ntop test
    - fix test failing - byte len
    
    * fix test failing - byte len
    
    * debugging odd windows build failure
    
    * debugging odd windows build failure
    
    * more experiments to figure out the windows failure
    
    * try manual assigment on InAddr
    
    Co-authored-by: Jaremy Creechley <jaremy.creechley@panthalassa.com>
    (cherry picked from commit 4b5cecd)
    narimiran and Jaremy Creechley committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    55907a8 View commit details
    Browse the repository at this point in the history
  3. fix wrong backport

    narimiran committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    73c4ede View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Fix bug in freshVarForClosureIter. Fixes #18474 (#19675) [backport]

    * Fix bug in freshVarForClosureIter. Fixes #18474.
    
    freshVarForClosureIter was returning non-fresh symbols sometimes.
    Fixed by making addField return the generated PSym.
    
    * remove discardable
    
    Co-authored-by: Nick Smallbone <nick@smallbone.se>
    (cherry picked from commit 83dabb6)
    2 people authored and narimiran committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    92457cb View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. fix #18986; Import/except doesn't work on devel [backport: 1.6] (#19687)

    * fix #18986; Import/except doesn't work on devel [backport: 1.6]
    
    * add testcase
    
    (cherry picked from commit 5a995ff)
    ringabout authored and narimiran committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3177e16 View commit details
    Browse the repository at this point in the history
  2. [backport] fix broken SSL tests (#19684)

    * [backport] fix broken SSL tests
    
    * remove a flaky one
    
    (cherry picked from commit c322faa)
    narimiran committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    dcc40b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    bb937f2 View commit details
    Browse the repository at this point in the history
  2. improve the error messages for std/tasks [backport: 1.6] (#19695)

    (cherry picked from commit c8aeea9)
    ringabout authored and narimiran committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    b96954e View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Configuration menu
    Copy the full SHA
    6365d8c View commit details
    Browse the repository at this point in the history
  2. fix stylecheck error with asyncdispatch (#19350)

    * stylecheck usages part two: stdlib cleanup
    
    typeinfo.nim: importCompilerProc => importcompilerproc
    
    nre.nim: newLineFlags => newlineFlags
    
    system.nim: JSRoot => JsRoot
    
    ref #19319
    
    * prefer importCompilerProc
    
    * fix stylecheck error with asyncdispatch
    
    it is a partial regression since #12842
    
    * add tests
    
    * don't use echo in tests
    
    (cherry picked from commit 92e5573)
    ringabout authored and narimiran committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e22d494 View commit details
    Browse the repository at this point in the history
  3. fix stylecheck bug with nre (#19356)

    * stylecheck usages part two: stdlib cleanup
    
    typeinfo.nim: importCompilerProc => importcompilerproc
    
    nre.nim: newLineFlags => newlineFlags
    
    system.nim: JSRoot => JsRoot
    
    ref #19319
    
    * prefer importCompilerProc
    
    * fix stylecheck error with asyncdispatch
    
    it is a partial regression since #12842
    
    * add tests
    
    * don't use echo in tests
    
    * fix stylecheck bug with nre
    
    * Update compiler/linter.nim
    
    * no need to check dotexpr again
    
    * neither did let/var/const
    
    (cherry picked from commit 00775f6)
    ringabout authored and narimiran committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    9035618 View commit details
    Browse the repository at this point in the history
  4. stylecheck usages part two: stdlib cleanup (#19338)

    * stylecheck usages part two: stdlib cleanup
    
    typeinfo.nim: importCompilerProc => importcompilerproc
    
    nre.nim: newLineFlags => newlineFlags
    
    system.nim: JSRoot => JsRoot
    
    ref #19319
    
    * prefer importCompilerProc
    
    (cherry picked from commit ae92eac)
    ringabout authored and narimiran committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d38177b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. StringStreams no longer errors when intialized with literals on arc/o…

    …rc (#19708)
    
    (cherry picked from commit 26acc97)
    beef331 authored and narimiran committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    fcd05bd View commit details
    Browse the repository at this point in the history
  2. fix #19680; check if stderr is static (#19709)

    (cherry picked from commit 26bcf18)
    ringabout authored and narimiran committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    2a68fa7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Fix doc: list of async backends (#19741)

    (cherry picked from commit 02e8aa9)
    huantianad authored and narimiran committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    88573da View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. fix #19435; don't create TypeBoundOps for tyOpenArray, tyVarargs [bac…

    …kport: 1.6] (#19723)
    
    * fix #19435; openArray wronyly registers typebounds
    
    * add testcase
    
    * don't create TypeBoundOps for tyOpenArray, tyVarargs
    
    (cherry picked from commit efaa677)
    ringabout authored and narimiran committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    f194356 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    151b4cc View commit details
    Browse the repository at this point in the history
  3. Really fix StringStream with ARC at compile-time, improve streams test (

    #19739)
    
    * Fix compile-time StringStream with ARC
    
    * make readDataStr work with ARC, improve test
    
    (cherry picked from commit 2f32b45)
    Danil Yarantsev authored and narimiran committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    b1045cb View commit details
    Browse the repository at this point in the history
  4. fix NimNode comment repr() regression [backport: 1.2] (#19726)

    (cherry picked from commit 15ae932)
    ringabout authored and narimiran committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    85841cd View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. use signed comparisons for the index checking in the hope it improves…

    … the code generation (#19712)
    
    (cherry picked from commit ef4ac5a)
    Araq authored and narimiran committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    0e5bf59 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. fixes #18612; apply cache and memcmp for methods in arc/orc (#19749)

    * try using endsWith
    
    * use memcmp
    
    * add cache
    
    * cleanup
    
    * better
    
    * minor
    
    * fix
    
    * improve test coverage for methods with ARC
    
    (cherry picked from commit 8bfc396)
    ringabout authored and narimiran committed May 2, 2022
    Configuration menu
    Copy the full SHA
    1788b8b View commit details
    Browse the repository at this point in the history