* fixes #22360; compare with the half of randMax

* add a test

(cherry picked from commit f3a7622)

(cherry picked from commit 825a0e7)

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit d37b620)

(cherry picked from commit fb7acd6)

ref 0d3bde9#commitcomment-122093273

(cherry picked from commit 7c2a2c8)

#21172)

* fix #20883 Unspecified generic on default value segfaults the compiler

* fallback to isGeneric

* change to closer error

* Update t20883.nim

(cherry picked from commit 26f1830)

#22245)

* Fix searchExtPos so that it returns -1 when the path is not a file ext

* fix comparision expression

* Remove splitDrive from searchExtPos

(cherry picked from commit db435a4)

(cherry picked from commit 9872453)

…after-free (#22386)

Prevent destruction of gFuns before callClosures

(cherry picked from commit e039690)

* add test for #3907

(cherry picked from commit 137d608)

…22401)

Delete parse directory

(cherry picked from commit 614a18c)

#20683)

* fix #18823 Passing Natural to bitops.BitsRange[T] parameter in generic proc is compile error

(cherry picked from commit 37d8f32)

* clean up gc:arc/orc in docs

* in error messages

(cherry picked from commit 10a6e4c)

* fix #20891 Illegal capture error of env its self

* fix innerClosure too earlier, make condition shorter

(cherry picked from commit 989da75)

* fix #12938 nim compiler assertion fail when literal integer is passed as template argument for array size

* use new flag tfImplicitStatic

* fix

* fix #14193

* correct tfUnresolved add condition

* clean test

(cherry picked from commit d53a89e)

* Remove call-specific replaceTypeVarsN

* Run for all call kinds and ignore typedesc

* Testcase

---------

Co-authored-by: SirOlaf <>
(cherry picked from commit baf3504)

…0659)

* fix #19304 Borrowing std/times.format causes Error: illformed AST

* follow suggestions

* mitigate for #4121

* improve error message

(cherry picked from commit 2aab03b)

* fixes move sideeffects issues [backport]

* fix openarray

* fixes openarray

(cherry picked from commit faf1c91)

…22450)

* fix #22448

* add test

(cherry picked from commit 48da472)

…2472)

fixes #22469; generates `nimTestErrorFlag` for top level statements

(cherry picked from commit 09d0fda)

fixes #22490, fixes #22491, adapts #22029 to type conversions

(cherry picked from commit 98c39e8)

* Keep return in mind for sink
* Keep track of return using bool instead of mode
* Update compiler/injectdestructors.nim
* Add back IsReturn

---------

Co-authored-by: SirOlaf <>
Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
(cherry picked from commit c0ecdb0)

allow non-pragma special words as macro pragmas

fixes #22525

(cherry picked from commit 602f537)

* round out tuple unpacking assignment, support underscores

fixes #18710

* fix test messages

* use discard instead of continue

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>

---------

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
(cherry picked from commit 53d43e9)

* Fix `getAppFilename` exception handling

avoid platform-dependendent error handling strategies

* more fixes

* space

(cherry picked from commit bc9785c)

…hing twice (#22549)

fixes a strictdef ten years long vintage bug

(cherry picked from commit 1013378)

#22559)

* fix #22548;environment misses for type reference in iterator access nested in closure

* fix #21737

* Update lambdalifting.nim

* remove containsCallKinds

* simplify

(cherry picked from commit 0b78b7f)

fixes #12929

(cherry picked from commit 6b955ac)

…22611)

* type annotations for variable tuple unpacking, better error messages

closes #17989, closes nim-lang/RFCs#339

* update grammar

* fix test

(cherry picked from commit ba158d7)

…#22614)

* fixes #22613; Default value does not work with object's discriminator

fixes #22613

* merge branches

* add a test case

* fixes status

* remove outdated comments

* move collectBranchFields into the global scope

(cherry picked from commit affd3f7)

fixes #19849

(cherry picked from commit 53d9fb2)

resolve local symbols in generic type call

fixes #14509

(cherry picked from commit f1789cc)

* fixes internal error: no generic body fixes #1500

* adds guard

* adds guard

* removes unnecessary test

* refactor: extracts containsGenericInvocationWithForward

(cherry picked from commit 0c6e138)

…agmas are not being cached (#22622)

remove `tfSendable` from `eqTypeFlags`

(cherry picked from commit 9f1fe8a)

fixes #20543

(cherry picked from commit bd6adbc)

…22606)

fixes #22598, properly fixes #21887 and fixes test case issue number

When an enum field sym choice has to choose a type, check if its name is
ambiguous in the local scope, then check if the first symbol found in
the local scope is the first symbol in the sym choice. If so, choose
that symbol. Otherwise, give an ambiguous identifier error.

The dependence on the local scope implies this will always give
ambiguity errors for unpicked enum symchoices from generics and
templates and macros from other scopes. We can change `not
isAmbiguous(...) and foundSym == first` to `not (isAmbiguous(...) and
foundSym == first)` to make it so they never give ambiguity errors, and
always pick the first symbol in the symchoice. I can do this if this is
preferred, but no code from CI seems affected.

(cherry picked from commit 480e98c)

fixes #22639 for the third time

Nodes generated by `getType` for `tyGenericInst` types, instead of
having the original `tyGenericInst` type, will have the type of the last
child (due to the `mapTypeToAst` calls which set the type to the given
argument). This will cause subsequent `getType` calls to lose
information and think it's OK to use the sym of the instantiated type
rather than fully expand the generic instantiation.

To prevent this, update the type of the node from the `mapTypeToAst`
calls to the full generic instantiation type.

(cherry picked from commit ed9e3cb)

Close #21742

Checking if there's any side-effects and if just changing typeRel is
adequate for this issue before trying to look into related ones.

`skipBoth` is also not that great, it can lead to code that works
sometimes but fails when the proc is instantiated with branching
aliases. This is mostly an issue with error clarity though.

---------

Co-authored-by: SirOlaf <unknown>
Co-authored-by: SirOlaf <>
(cherry picked from commit 2a8c759)

…s fields (#22665)

fixes #22662 Procs with constructor pragma doesn't initialize object's
fields

---------

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
(cherry picked from commit d45270b)

fixes #22664

(cherry picked from commit 5f13e15)

It's used in `newSeqUninitialized`.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit 8853fb0)

(cherry picked from commit 2ce9197)

* `PrepareSeqAdd`
* `add`
* `setLen`
* `grow`

Merge after #21842.

---------

Co-authored-by: ringabout <43030857+ringabout@users.noreply.github.com>
(cherry picked from commit fbb5ac5)

follow up #11955

(cherry picked from commit b1a8d69)

`semtempl` is refactored to combine the uses of `getIdentNode`,
`onlyReplaceParams`, `isTemplParam` and most of `replaceIdentBySym` into
a single `getIdentReplaceParams` proc. This might fix possible problems
with injections of `nkAccQuoted`.

Some special word comparison in `ast` and `semtempl` are also made more
efficient.

(cherry picked from commit ac1804a)

(cherry picked from commit 38b5823)

fixes #22699

(cherry picked from commit 8836207)

Close #22713

---------

Co-authored-by: SirOlaf <>
(cherry picked from commit fcf4c1a)

fixes #22700

(cherry picked from commit 63c2ea5)