Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nim-lang/Nim Loading
base: v1.2.4
Choose a base ref
...
head repository: nim-lang/Nim Loading
compare: v1.2.6
Choose a head ref
  • 20 commits
  • 27 files changed
  • 10 contributors

Commits on Jul 21, 2020

  1. SSL_CTX_load_verify_locations parameters are reversed (#14815) [backp…

    …ort]
    
    (cherry picked from commit d968163)
    aguspiza authored and narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    4d6cb1f View commit details
    Browse the repository at this point in the history
  2. Fix #14911 (#14922) [backport]

    * Fix #14911
    
    * Add testcase
    
    * Fix test
    
    (cherry picked from commit 5bd2da3)
    Clyybber authored and narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    1b093d7 View commit details
    Browse the repository at this point in the history
  3. fix #14082, don't crash on incorrectly formatted input (#14977) [back…

    …port]
    
    (cherry picked from commit c625130)
    narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    27acb43 View commit details
    Browse the repository at this point in the history
  4. fix #9771 (#14357)

    * fix #9771
    * map SQLLEN SQLULEN
    * fix proc params take TSqlLen
    
    Co-authored-by: bung87 <crc32@qq.com>
    (cherry picked from commit ce0552c)
    bung87 authored and narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e854d38 View commit details
    Browse the repository at this point in the history
  5. fix odbc regressions (#15009) [backport]

    * fix odbc regressions
    
    * make only necessary changes
    
    (cherry picked from commit edbbbdf)
    cooldome authored and narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    28bc815 View commit details
    Browse the repository at this point in the history
  6. [Backport] Fixes callbacks being dropped on Linux/macOS/BSD. (#15012)

    Fixes #15003.
    
    This is a serious bug which occurs when data cannot be read/sent
    immediately and there are a bunch of other read/write events
    pending. What happens is that the new events are dropped which
    results in the case of the reported bug resulted in some data not
    being sent (!).
    
    (cherry picked from commit 1e3a0ef)
    dom96 authored and narimiran committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    ddcbc1a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. fix several newline problems (#15028) [backend]

    * prevent newlines where they shouldn't be
    * 'contentLength' shouldn't be negative
    
    (cherry picked from commit 5fafa2f)
    narimiran committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    e71395f View commit details
    Browse the repository at this point in the history
  2. asyncftpclient.nim - don't assume a sufficiend line length (#14973)

    (cherry picked from commit f4f21c8)
    narimiran committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    170f5b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. enforce browsers.nim only handles URLs [backport] (#15045)

    (cherry picked from commit 925dd92)
    Araq authored and narimiran committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d0a2857 View commit details
    Browse the repository at this point in the history
  2. bump NimVersion to 1.2.5

    narimiran committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    378dc7c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Fulfill #14995 (comment) (#15104)

    request.  This can be conceived as an alternate, more capable resolution of
      #12200
    than
      #12208
    
    The code re-org idea here is to upgrade tablimpl.nim:`delImpl`/`delImplIdx`
    to abstract client code conventions for cell emptiness & cell hashing via
    three new template arguments - `makeEmpty`, `cellEmpty`, `cellHash` which
    all take a single integer argument and clear a cell, test if clear or
    produce the hash of the key stored at that index in `.data[]`.
    
    Then we update the 3 call sites (`Table`, `CountTable`, `SharedTable`) of
    `delImpl`/`delImplIdx` by defining define those arguments just before the
    first invocation as non-exported templates.
    
    Because `CountTable` does not save hash() outputs as `.hcode`, it needs a
    new tableimpl.nim:`delImplNoHCode` which simply in-lines the hash search
    when no `.hcode` field is available for "prefix compare" acceleration.
    It is conceivable this new template could be used by future variants, such
    as one optimized for integer keys where `hash()` and `==` are fast and
    `.hcode` is both wasted space & time (though a small change to interfaces
    there for a sentinel key meaning "empty" is needed for maximum efficiency).
    
    We also eliminate the old O(n) `proc remove(CountTable...)` in favor of
    simply invoking the new `delImpl*` templates and take care to correctly
    handle the case where `val` is either zero for non-existent keys in `inc`
    or evolves to zero over time in `[]=` or `inc`.
    
    The only user-visible changes from the +-42 delta here are speed, iteration
    order post deletes, and relaxing the `Positive` constraint on `val` in
    `proc inc` again, as indicated in the `changelog.md` entry.
    
    (cherry picked from commit b2a1944)
    c-blake authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    c804e55 View commit details
    Browse the repository at this point in the history
  2. bump NimVersion to 1.2.6

    narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    c0e1ee9 View commit details
    Browse the repository at this point in the history
  3. fixes #15044 [backport:1.2]

    (cherry picked from commit c90c53e)
    Araq authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    b4ccdf8 View commit details
    Browse the repository at this point in the history
  4. fixes #15056 [backport]

    (cherry picked from commit 12a9fe0)
    Araq authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    df490bd View commit details
    Browse the repository at this point in the history
  5. fix #14534 (#15060) [backport]

    (cherry picked from commit 9746868)
    bung87 authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    a3f00b8 View commit details
    Browse the repository at this point in the history
  6. fixes #15038 [backport:1.2]

    (cherry picked from commit aae998f)
    Araq authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    f2844ba View commit details
    Browse the repository at this point in the history
  7. parsecsv: fix '\0' being displayed as '0' in docs (#15086) [backport]

    (cherry picked from commit a62bc55)
    Jjp137 authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    896c3c4 View commit details
    Browse the repository at this point in the history
  8. fixes #14189 (#15080) [backport]

    (cherry picked from commit 191c388)
    bung87 authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    9d11fc0 View commit details
    Browse the repository at this point in the history
  9. fixes #14616 [backport:1.2] (#15109)

    (cherry picked from commit a3a87cd)
    Araq authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    e9d6d2b View commit details
    Browse the repository at this point in the history
  10. Attempt to explain better why delImplIdx is the way it is. Maybe this…

    … can (#15108)
    
    avoid future implementation mischief.  (Maybe not.  Sometimes, general
    distrust of theory leads people to distrust simple reasoning over times
    from CPUs trying as hard as possible to mask DRAM latency via pre-fetch.)
    
    (cherry picked from commit 196e747)
    c-blake authored and narimiran committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    bf320ed View commit details
    Browse the repository at this point in the history
Loading