Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should call `./koch tools` ; right now `nimfind` isn't even being compiled #10039

Closed
timotheecour opened this issue Dec 19, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@timotheecour
Copy link
Contributor

commented Dec 19, 2018

it'd be more DRY for CI to call ./koch tools instead of duplicating its logic, nimfind was added to ./koch tools but is not being tested, so introducing compile errors won't even be tested for (i just tried)
EDIT:

CI should call ./koch tools ; right now nimfind isn't even being compiled

Example

N/A

Current Output

N/A

Expected Output

N/A

Possible Solution

it'd be more DRY for CI to call ./koch tools instead of duplicating its logic inside travis/appveyor, nimfind was added to ./koch tools but is not being tested, so introducing compile errors won't even be tested for (i just tried); Hence I suggest:
replace

- ./koch nimsuggest

by

- ./koch tools

so it'll at least build all tools (even if not testing all of them)
ditto with appveyor

Additional Information

N/A

@krux02

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2018

We have issue templates for a reason. Please use them.

@krux02 krux02 closed this Dec 21, 2018

@timotheecour

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2018

just did, not sure what it buys in terms of clarity in this issue; most of the entries are N/A in this case; IMO it makes the issue less readable, not more readable than the simple 1 line explanation I had before. YMMV

@timotheecour timotheecour reopened this Dec 21, 2018

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 9, 2019

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 9, 2019

@timotheecour timotheecour self-assigned this Jan 9, 2019

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 10, 2019

@Araq Araq closed this in #10242 Jan 10, 2019

Araq added a commit that referenced this issue Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.