New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimscript doesn't raise any exceptions #10240

Closed
genotrance opened this Issue Jan 9, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@genotrance
Copy link
Contributor

genotrance commented Jan 9, 2019

I was working on implementing stdin.readLine() support in nimscript and was unable to get EOFError exposed. Just to verify, I tried to use the existing rmFile() code which should raise OSError if you try to remove a file that is currently in use. This doesn't work despite being raised in checkOsError() in nimscript.nim.

Build and run any test.exe which stays resident and then try nim e test2.nims with the following code:

rmFile("test.exe")

Command just runs with no errors and test.exe is still present. Verified failure with #head 0.19.2 and 0.19.0.

@genotrance

This comment has been minimized.

Copy link
Contributor

genotrance commented Jan 9, 2019

Went further back and tested with 0.18.0, 0.17.2, 0.16.0 and 0.15.2 and issue is still present. Unclear where it worked.

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Jan 11, 2019

Can't reproduce.

EDIT: Now I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment