Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittest module uses `programResult` to report number of failures which can wrap #10261

Closed
onqtam opened this issue Jan 10, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@onqtam
Copy link
Contributor

commented Jan 10, 2019

the exit code of a program can wrap at values as low as 256 (for some platforms) so depending on the exit code of a program for the number of failed tests can be misleading - and might even wrap to 0 - as if no tests have failed!

typically testing frameworks return either success or failure (meaning 0 or 1) - see these links:

catchorg/Catch2#1146
catchorg/Catch2#1410
https://unix.stackexchange.com/questions/418784/what-is-the-min-and-max-values-of-exit-codes-in-linux

@Araq

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

In addition to that, I don't like system.programResult, other languages don't have the need for it either.

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 10, 2019

@timotheecour

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

=> PR #10264

@Araq Araq closed this in 540d102 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.