Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashes:hash returns different values on Windows/Linux #10771

Closed
genotrance opened this issue Mar 2, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@genotrance
Copy link
Contributor

commented Mar 2, 2019

Detected in nightlies build for runnableExamples:

https://travis-ci.org/nim-lang/nightlies/builds/500677963

  runnableExamples:
    doAssert hash("abracadabra") == -5600162842546114722
    doAssert hash("Abracadabra") == 2068684413884279454

Value is correct on my Linux x64 machine like on Travis but on Windows, it returns 1766020087. Not sure what value is returned on Linux x32 but that fails on Travis.

Commit that broke this:

https://github.com/nim-lang/Nim/pull/10752/files#diff-466aee2707291e60fe359bda6b675b86R146

cc: @narimiran

@narimiran

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Thanks for bringing it to my attention, will change it.

Btw, how come this passes both Travis and Appveyor here and fails in nightlies?

@narimiran narimiran self-assigned this Mar 3, 2019

@narimiran narimiran closed this in 792dfac Mar 3, 2019

@genotrance

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

I don't think the CI runs koch docs like nightlies does. Only nim doc tests snippets and runnable examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.