Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.joinPaths documentation is inaccurate; should reference uri.combine #10836

Closed
koranza opened this issue Mar 13, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@koranza
Copy link
Contributor

commented Mar 13, 2019

The documentation for os.joinPaths (/) says "Other path separators not located on boundaries won't be modified", but this is no longer the case.

os.joinPaths calls pathnorm.addNormalizePath which can modify path separators not at boundaries.

Example

import os

var base = r"file:///c:/WINDOWS/"
var filePath = r"/write.exe"

echo base / filePath

Current Output

file:/c:/WINDOWS/write.exe

Expected Output

file:///c:/WINDOWS/write.exe

Possible Solutions

The documentation should mention that it normalizes the paths and also link to uri.combine (/) so that its usage is more clear, or it should detect that the path is URI and join them with uri.combine

narimiran added a commit to narimiran/Nim that referenced this issue Mar 19, 2019

@Araq Araq closed this in 1eefbf6 Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.