Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimsuggest, nim check segfault when using bindSym and doAssert #10901

Closed
pgkos opened this issue Mar 24, 2019 · 1 comment

Comments

@pgkos
Copy link
Contributor

commented Mar 24, 2019

Nimsuggest and nim check crash with SIGSEGV when run on the following (invalid) example:

Example

import macros

macro foo(): untyped =
  let sym = bindSym("bar")
  doAssert sym.kind == nnkSym

foo()

Current Output

SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Expected Output

No crash.

Additional Information

$ nim -v
Nim Compiler Version 0.19.9 [Linux: amd64]
Compiled at 2019-03-23
Copyright (c) 2006-2019 by Andreas Rumpf

active boot switches: -d:release
@narimiran

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

let sym = bindSym("bar") raises: Error: undeclared identifier: 'bar'

...and after that, (do)assert causes SIGSEGV, even if you do plain and simple assert true.

@Araq Araq closed this in 7817485 Jul 10, 2019

narimiran added a commit that referenced this issue Jul 15, 2019

fixes #10901
(cherry picked from commit 7817485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.