Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64.encode should not "prettify" the result by default #11364

Closed
alaviss opened this issue May 31, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@alaviss
Copy link
Contributor

commented May 31, 2019

Description

Currently base64.encode prettify the result by adding CRLF after every 75 characters, which is not really useful for anything except printing. I've found myself using encode(newLine = "") a bit too much now for interfacing with various systems (ie. HTTP Basic Authentication).

My suggestion would be that we remove this feature or at least disable it by default.

Alternatives

encode(newLine = "")

@Araq Araq added the Showstopper label Jun 1, 2019

@Araq

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Now is the time to do this, before 0.20 is out...

Araq added a commit that referenced this issue Jun 2, 2019

@Araq Araq closed this in a68fe3d Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.