strutils.formatEng relies on a distinction of "" and nil string

[krux02]

As discussed earlier the nil value strings and seq types should go away. strutils.formatEng relies on the distinction of nil strings and empty strings

This causes a problem in this PR: #6206

[dom96]

As discussed earlier the nil value strings and seq types should go away.

Where was this discussed?

[krux02]

In the irc chat.

[dom96]

A link would be nice, but okay :)

[krux02]

Sorry for not putting a link. I know there are irc logs, but I don't have grep access to them. Maybe you do have that, and it is very tedious to search on the web access through the IRC logs.

[dom96]

The only distinction I see is with the unit parameter, is that what you meant? https://github.com/nim-lang/Nim/blob/devel/lib/pure/strutils.nim#L2095

If so then I guess we should be using an Option[string] for that, fairly trivial change, no?

Unfortunately I think that a lot of code in the wild uses this sort of thing. :\

[dom96]

Giving high priority because this is a breaking change.