Template error can be interpreted incorrectly because of bad error message

[BitPuffin]

import db_sqlite

var db = Open(connection="foo.db", user="rumpf", password="fpmur", database="mydb")

proc getFromWhere*(id, row, table: string): TRow =
  result = db.getRow(sql"select 1 from ? where ? = ?", table, row, id)

template getFrom*(id, table: string): expr =
  getFromWhere(id, "id", table)
  ## foo! this line causes error

discard "4".getFrom("users") # Should raise exception (because table users dosen't \
                                          # exist and neither does user 4) but doesn't compile

[Varriount]

What error do you get? What's confusing about it?
The above code compiles successfully for me, and when run, gives the error "Error: unhandled exception: no such table: users [EDb]"

Are you saying that it should error on line 10 instead? I don't know about that, because the value returned on line 9 is what's being discarded, since the comment is considered significant for whatever reason.

I thought you weren't able to reproduce this (bug?), but I'm able to when I turn getFrom into a proc. The question is what kind of behavior is correct. I'm used to this now, but it is indeed a little confusing at first. Either way, I think it should be consistent for all block types.

The error when getFrom is a proc is this:

comment_bug.nim(12, 11) Info: instantiation from here
comment_bug.nim(9, 14) Error: value returned by statement has to be discarded

[Varriount]

Yes, but templates are inlined. Their body is copied into any context they are used in. When getFrom is used, it is essentially replaced with getFromWhere, along with it's arguments. It's confusing, unless you stop to think about what templates really do, vs what procedures do.

[Araq]

Can't reproduce, compiles for me...

[Araq]

No feedback. Closing.