Spurious "not GC-safe" warning

[mooskagh]

Code:

import os
import ospaths
import parsetoml

proc GetConfigFileName() : string =
  return joinPath(getAppDir(), "lc0client.toml")

proc ReadConfig() : TomlTableRef =
  return parseFile(GetConfigFileName())

Check with:

$ nim check --verbosity:2 a.nim

Unreasonable warning:

a.nim(9, 19) Warning: not GC-safe: 'parseFile(GetConfigFileName())' [GcUnsafe]

[Araq]

We are not responsible for parsetoml. Reopen when you have a test case that shows a wrong Nim compiler / stdlib behaviour.

[dom96]

I went through (admittedly skimmed) parsetoml and I didn't see anything that could be causing this gc unsafe warning. It's also odd that it only shows up under higher verbosity?

[Araq]

It's also odd that it only shows up under higher verbosity?

No, that's what the compiler does. It emits more warnings under a higher verbosity level.

[Araq]

This is likely why:

# Forward declaration
proc parseValue(state: var ParserState): TomlValueRef

[PMunch]

Why does that forward declaration make it not GC safe?

[dom96]

We need better errors for this IMO

[Araq]

No test case. Closing.