Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish completely removing web folder #9304

Closed
timotheecour opened this issue Oct 11, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@timotheecour
Copy link
Contributor

commented Oct 11, 2018

/cc @narimiran
after #9290 and #9233

  • revive #9277 after addressing remaining failures, see also:

#9277 (comment)

@kaushalmodi

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2018

But looks like nimblepkglist.nim needs to be kept for now. It seems like the cleanup in done there (until it's deemed that nimblepkglist.nim is no longer needed).

#9277 (comment)

@timotheecour

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

i thought it was still there as an accident, feel free to close if it's intended to be there

@timotheecour

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

@Araq suggested:

From IRC (bridge bot) @FromIRC 03:57
@narimiran: move nimblepkglist.nim to tools/

narimiran added a commit to narimiran/Nim that referenced this issue Oct 11, 2018

@narimiran

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

PR submitted, let's wait for the tests.

@Araq Araq closed this in c492a7f Oct 12, 2018

krux02 added a commit to krux02/Nim that referenced this issue Oct 15, 2018

complete removal of web folder, fixes nim-lang#9304 (nim-lang#9310)
* complete removal of web folder, fixes nim-lang#9304

* remove `buildJS`

narimiran added a commit to narimiran/Nim that referenced this issue Oct 31, 2018

complete removal of web folder, fixes nim-lang#9304 (nim-lang#9310)
* complete removal of web folder, fixes nim-lang#9304

* remove `buildJS`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.