New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimpretty joins regular and doc comment #9400

Closed
timotheecour opened this Issue Oct 16, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@timotheecour
Copy link
Collaborator

timotheecour commented Oct 16, 2018

  • bug 1: regular comment appended to doc comment
  • bug 2: file ends with 2 empty newlines instead of 1
  • bug 3: alignment is weird (but that is already covered by #9399)
proc fun*()=
  echo "ok"
  ## doc comment
  # regular comment

produces:

proc fun*() =
  echo "ok"
  ## doc comment              # regular comment

@krux02 krux02 changed the title [nimpretty] regular comment appended to doc comment nimpretty joins regular and doc comment Oct 20, 2018

@Araq Araq closed this in 72370c8 Oct 23, 2018

narimiran added a commit to narimiran/Nim that referenced this issue Oct 31, 2018

narimiran added a commit to narimiran/Nim that referenced this issue Nov 1, 2018

narimiran added a commit that referenced this issue Nov 1, 2018

narimiran added a commit that referenced this issue Nov 1, 2018

closes #9400
(cherry picked from commit 72370c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment