New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfragment_gc test is flaky on OSX #9421

Closed
timotheecour opened this Issue Oct 17, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@timotheecour
Copy link
Collaborator

timotheecour commented Oct 17, 2018

eg: https://api.travis-ci.org/v3/job/442929178/log.txt

FAIL: tfragment_gc.nim C
Test "tests/fragmentation/tfragment_gc.nim" in category "fragmentation"
Failure: reOutputsDiffer
Expected:
occupied ok: true
total ok: true

Gotten:
occupied ok: true
total peak memory 247.18MiB
total ok: false

search for tfragment_gc and you'll see it affects a number of PR's

Note: this is a bit troubling, why does OSX on travis use so much memory?

(82 * 1024 * 1024) = 86MB, but this uses 247MB

this seems like a regression

here's a snippet:

import strutils, data

proc main =
  var m = 0
  # Since the GC test is slower than the alloc test, we only iterate 100_000 times here:
  for i in 0..100_000:
    let size = sizes[i mod sizes.len]
    let p = newString(size)
 #   c_fprintf(stdout, "iteration: %ld size: %ld\n", i, size)

main()

let total = getTotalMem()

first happened recently

searching through tfragment_gc in PR's, the 1st time I see this failure happening on OSX on travis is #9388 ie around october 16 2018 (1 day ago)

@alaviss

This comment has been minimized.

Copy link
Contributor

alaviss commented Oct 18, 2018

It might be worth noting that I've also reproduced this a lot of time on Haiku x86_64.

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Oct 18, 2018

It doesn't fail all the time though, sometimes it's green, but I'll disable these tests now.

@timotheecour timotheecour changed the title [urgent] [regression] [CI] tfragment_gc test fails on OSX [urgent] [regression] [CI] tfragment_gc test flaky on OSX Oct 18, 2018

@Araq Araq closed this in 381498b Oct 18, 2018

@timotheecour

This comment has been minimized.

Copy link
Collaborator

timotheecour commented Oct 18, 2018

I'll disable these tests now

ok but let's keep this issue open please, as there's an underlying issue

@timotheecour timotheecour changed the title [urgent] [regression] [CI] tfragment_gc test flaky on OSX [TODO] [urgent] [regression] [CI] tfragment_gc test flaky on OSX Oct 18, 2018

@timotheecour timotheecour changed the title [TODO] [urgent] [regression] [CI] tfragment_gc test flaky on OSX [TODO] [regression] [CI] tfragment_gc test flaky on OSX Oct 18, 2018

@Araq Araq reopened this Oct 18, 2018

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Oct 18, 2018

Is there though? I haven't tried yet but I bet I cannot reproduce this problem on my OSX box.

@krux02 krux02 changed the title [TODO] [regression] [CI] tfragment_gc test flaky on OSX tfragment_gc test is flaky on OSX Oct 20, 2018

@Araq Araq removed the Regression label Oct 26, 2018

@timotheecour

This comment has been minimized.

Copy link
Collaborator

timotheecour commented Oct 26, 2018

I cannot reproduce this problem on my OSX box

well not on your OSX box (nor mine, last time I tried), but on travis's OSX box it happens; isn't that something we should consider?
could that be due to environmental difference eg less RAM in these machines?

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Oct 26, 2018

I don't know but this tests runs in parallel with lots of others and always was fragile, so it's not a regression.

narimiran added a commit to narimiran/Nim that referenced this issue Oct 31, 2018

narimiran added a commit to narimiran/Nim that referenced this issue Nov 1, 2018

narimiran added a commit that referenced this issue Nov 1, 2018

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Jan 13, 2019

This test was disabled.

@Araq Araq closed this Jan 13, 2019

@timotheecour timotheecour added the OSX label Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment