Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

every binary cmd line option should allow on/off switch #9629

Closed
timotheecour opened this issue Nov 6, 2018 · 0 comments

Comments

Projects
None yet
4 participants
@timotheecour
Copy link
Contributor

commented Nov 6, 2018

as an example, --listFullPaths doesn't allow --listFullPaths:off; so it can't be undone if user has it in ~/.config/nim/nim.cfg
this would've allowed a simple fix for Varriount/NimLime#118 where root cause was that --listFullPaths was not being supported
there are other examples like that.

proposal

every binary switch can be passed an on/off value, eg:

--listFullPaths # still allowed
--listFullPaths:on # same as --listFullPaths
--listFullPaths:off # unsets --listFullPaths

implementation: just use processOnOffSwitch

@krux02 krux02 self-assigned this Nov 6, 2018

@narimiran narimiran removed the RFC label Jan 2, 2019

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 18, 2019

@timotheecour timotheecour self-assigned this Jan 18, 2019

@Araq Araq closed this in #10353 Jan 18, 2019

Araq added a commit that referenced this issue Jan 18, 2019

fix #9629 every binary cmd line option allows on/off/empty=on (#10353)
* fix #9629 every binary cmd line option allows on/off/empty=on

* workaround refs #10359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.