Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nimf as standardized extention for nim files with source code filter? #9647

Closed
timotheecour opened this issue Nov 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@timotheecour
Copy link
Contributor

commented Nov 7, 2018

https://nim-lang.org/docs/filters.html doesn't mention any extension for source code filter files; it was recently added to devel docs:

devel docs https://nim-lang.github.io/Nim/filters.html (not shown in older docs) show:

You can name your SCF file with any file extension you want, but the conventional extension is .tmpl

However, .tmpl is very generic and used by a ton of other code, see
https://github.com/search?q=extension%3A.tmpl+proc&type=Code
(one concrete example : https://github.com/Connor218/Burger/blob/ba814a4271c0fdc37a519348bacb49458997d2ec/node_modules/template/test/fixtures/_a.tmpl)

it also makes it hard to add a rule for .tmpl files so github would treat these (and highlight them etc) as Nim files

proposal and rationale

if this proposal is rejected, these files should be updated to use tmpl instead of nimf /cc @Varriount
https://github.com/Varriount/NimLime/blob/master/Syntaxes/Nim_Filter.YAML-tmLanguage
https://github.com/Varriount/NimLime/blob/master/Syntaxes/Nim_Filter.tmLanguage

@krux02

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

Is there anything that limits you from using nimf as the file ending for source code filter templates?

@dom96

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

sure, update the docs.

timotheecour added a commit to timotheecour/Nim that referenced this issue Nov 9, 2018

timotheecour added a commit to timotheecour/Nim that referenced this issue Nov 9, 2018

timotheecour added a commit to timotheecour/Nim that referenced this issue Nov 13, 2018

@Araq Araq closed this in #9658 Nov 14, 2018

Araq added a commit that referenced this issue Nov 14, 2018

timotheecour added a commit to timotheecour/Nim that referenced this issue Jan 14, 2019

fix (last?) remaining leftover from nim-lang#9647 : use nimf as stand…
…ardized extension for source code filters

Araq added a commit that referenced this issue Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.