Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospaths still referenced despite its deprecation #9671

Closed
timotheecour opened this issue Nov 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@timotheecour
Copy link
Contributor

commented Nov 9, 2018

changelog.md:75:8:- The `ospaths` module is now deprecated, use `os` instead. Note that
changelogs/changelog_0_19_0.md:226:41:- Added ``macros.getProjectPath`` and ``ospaths.putEnv`` procs to Nim's virtual
compiler/vmops.nim:24:10:template ospathsop(op) {.dirty.} =
compiler/vmops.nim:25:31:  registerCallback(c, "stdlib.ospaths." & astToStr(op), `op Wrapper`)
doc/codeowners.rst:54:5:os, ospaths                    dom96, araq
doc/contributing.rst:25:39:3. testament tests, eg: tests/stdlib/tospaths.nim (only used for Nim repo).
doc/contributing.rst:33:66:If you change the stdlib (anything under ``lib/``, eg ``lib/pure/ospaths.nim``),
doc/contributing.rst:56:20:eg ``tests/stdlib/tospaths.nim``; this allows additional features such as custom
doc/contributing.rst:200:48:See `parentDir <https://nim-lang.github.io/Nim/ospaths.html#parentDir%2Cstring>`_
doc/nims.rst:34:4:* `ospaths <ospaths.html>`_
lib/pure/os.nim:1937:10:#include ospaths
lib/pure/osproc.nim:18:7:#from ospaths import quoteShell, quoteShellWindows, quoteShellPosix
tests/assert/testhelper.nim:2:6:from ospaths import isAbsolute
tests/newconfig/tfoo.nims:6:13:# test that ospaths actually compiles:
tests/newconfig/tfoo.nims:7:8:import ospaths
tests/stdlib/tospaths.nim:2:11:  file: "tospaths.nim"
tests/stdlib/tospaths.nim:5:12:# test the ospaths module
tests/vm/tvmmisc.nim:4:8:import ospaths
tools/kochdocs.nim:98:10:lib/pure/ospaths.nim
@randydsmithjr

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2018

@Araq Araq closed this in #9750 Nov 19, 2018

Araq added a commit that referenced this issue Nov 19, 2018

@timotheecour

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

/cc @randydsmithjr
reopening:
we still have tests/stdlib/tospaths.nim
This is bad because now we have some redundant tests in tests/stdlib/tos.nim vs tests/stdlib/tospaths.nim
(eg normalizedPath)
Let's deal with this after #10018 is merged

ideally, tests/stdlib/tospaths.nim would be merged (properly, without duplicating stuff) inside tos.nim
even more ideally (but maybe later) would be converting some echo tests to doAssert tests in tos.nim

@timotheecour timotheecour reopened this Dec 18, 2018

@timotheecour timotheecour added the Easy label Dec 19, 2018

narimiran added a commit to narimiran/Nim that referenced this issue Jan 23, 2019

move tests from `tospaths` to `tos`, fixes nim-lang#9671
Also, change some of `echo`s to `doAssert`.

@Araq Araq closed this in f0be575 Jan 23, 2019

ThomasTJdev added a commit to ThomasTJdev/Nim that referenced this issue Jan 27, 2019

move tests from `tospaths` to `tos`, fixes nim-lang#9671
Also, change some of `echo`s to `doAssert`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.