New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCommand nop, outdated documentation #10254

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@Stromberg90
Copy link
Contributor

Stromberg90 commented Jan 10, 2019

When I used setCommand as shown in the example, I get this warning on build.
Warning: Using setCommand 'nop' is not necessary.

Maybe I'm missing something, but it seems like the documentation is outdated.

setCommand nop update documentation
When I used Warning: Using `setCommand 'nop'` is not necessary.
@Araq

This comment has been minimized.

Copy link
Member

Araq commented Jan 10, 2019

Hmm I don't understand this.

@Stromberg90

This comment has been minimized.

Copy link
Contributor

Stromberg90 commented Jan 10, 2019

I'm using nimble with a task in my .nimble file.
When using setCommand as shown in the documentation I get that warning.

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Jan 10, 2019

That seems to be a Nimble issue or at least something we need to discuss with @dom96

@dom96

This comment has been minimized.

Copy link
Member

dom96 commented Jan 11, 2019

Yes, I removed this from Nimble because I thought it was silly. IMO Nim should follow suit.

@Araq

This comment has been minimized.

Copy link
Member

Araq commented Jan 12, 2019

How does it work though?

@dom96

This comment has been minimized.

Copy link
Member

dom96 commented Jan 12, 2019

By assuming that it's always set to "nop"? I can't remember exactly, but likely something like that.

@Araq Araq merged commit 2823da5 into nim-lang:devel Jan 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Araq added a commit that referenced this pull request Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment