Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent common user config to interfere with testament #10573

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@timotheecour
Copy link
Contributor

commented Feb 6, 2019

I ran ``./koch tests r tests/ccgbugs/twrongrefcounting.nim` on #10559 and got the very unhelpful:

FAIL: tests/ccgbugs/twrongrefcounting.nim C
Test "tests/ccgbugs/twrongrefcounting.nim" in category "tests"
Failure: reNimcCrash
Expected:


Gotten:


ie, empty Gotten instead of:

Gotten:
system module needs: echoBinSafe

The root casue is switch("colors", "on") in my ~/.config/config.nims which messes with how testament verifies outputs;
note, this is a reasonable thing to put in a user config (I even had it under when not defined(testing): but that still didn't work; perhaps because not every call to nim inside testament has -d:testing

plus, might as well make it simple and working for everyone without requiring them to edit their user config

This PR fixes that robustly.

note

that would happen in other situations; eg with ./koch tests on a PR that has failures

@Araq Araq merged commit cf8366a into nim-lang:devel Feb 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timotheecour timotheecour deleted the timotheecour:pr_testament_config_nims branch Feb 6, 2019

timotheecour added a commit to timotheecour/Nim that referenced this pull request Feb 7, 2019

timotheecour added a commit to timotheecour/Nim that referenced this pull request Feb 7, 2019

Araq added a commit that referenced this pull request Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.