Skip to content

Conversation

mario-campos
Copy link

This patch fixes bug #1081 by adding an underscore _ before the number ('0'..'9') in the C source.

@Varriount
Copy link
Contributor

Since this affect code generation on a very large scale, I'm hesitant to pull this. I'll wait for approval from @Araq

@dom96
Copy link
Contributor

dom96 commented Apr 23, 2014

I think @Araq already said that he dislikes this PR.

@flaviut
Copy link
Contributor

flaviut commented Apr 24, 2014

Relevant IRC discussion:

(08:30:40 PM) Araq: xenagi: not really
(08:31:04 PM) xenagi: why not?
(08:32:24 PM) Araq: I think it's more complex than necessary
(08:34:59 PM) xenagi: hmm, i suppose some of those cases could be cascaded
(08:35:22 PM) flaviu: Couldn't it be done by just adding the underscore in all cases?
(08:35:46 PM) xenagi: yes
(08:35:51 PM) xenagi: should it?
(08:36:16 PM) Demos: ermmmm reserved names ahoy
(08:38:33 PM) flaviu: Araq: What do you think about appending _ to every name?
(08:38:50 PM) Araq: it's crap.
(08:38:57 PM) dom96: Why _?
(08:39:10 PM) dom96: Append 'ID' if the identifier begins with a number.
(08:39:22 PM) xenagi: _ would not hinder readability of the variable name
(08:39:35 PM) ***Araq hates C's __ASCII_ART__

@reactormonk
Copy link
Contributor

@iamrekcah in such a case, commit the whitespace changes into one commit and the relevant code changes into another commit.

@Varriount Varriount closed this May 21, 2014
@Varriount
Copy link
Contributor

Closed, as another PR solved this issue a bit more gracefully (according to Araq)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants