Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name mangling reversable unambiguously #11939

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@Clyybber
Copy link
Contributor

commented Aug 13, 2019

No description provided.

Clyybber added some commits Aug 13, 2019

@krux02

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

How does this change affect the ability to reverse the name mangling? To my understanding, this is still not reversible.

@Clyybber

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

It makes it possible to unambiguosly cut off the base64 decoded md5 hash that appears in the generated C code, since __ is not a valid part of identifiers in Nim.

@Araq Araq merged commit e6cb7e3 into nim-lang:devel Aug 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.