Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #12152 #12165

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@Araq
Copy link
Member

commented Sep 10, 2019

No description provided.

Araq added 2 commits Sep 10, 2019
@awr1

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Is there a good reason why all these tests aren't in their own test module?

@Araq

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

It can be more convenient to touch a stdlib module and to know its tests are in the same file and a single nim c -r file_i_just_touched.nim away.

@Araq Araq merged commit e134a72 into devel Sep 11, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Araq Araq deleted the araq-fixes-12152 branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.