Fixed readAllBuffer() to avoid adding garbage bytes at end. #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC |
|
I'm mostly interested in getting the bug fixed (so that, e.g., |
The function readAllBuffer() always returned a string that was a multiple of the BufSize in length, regardless of how many bytes were actually read, padding the result with garbage bytes on the last chunk. This fix properly trims the last chunk to its actual size.
|
Updated the pull request to remove the change to the buffer size. Benchmarking seems to indicate that speed gains, if any, are negligible. |
|
Looks ok to me. |
Araq
added a commit
that referenced
this pull request
May 31, 2014
Fixed readAllBuffer() to avoid adding garbage bytes at end.
Clyybber
added a commit
to Clyybber/Nim
that referenced
this pull request
Mar 7, 2024
## Summary * Remove `nkStmtListType` and `nkBlockType` node kinds and replace the remaining usages of `nkStmtListType` with `nkStmtListExpr` ## Details * `not nil` is implemented as a `TypeTrait` magic and no longer reaches mirgen * A workaround for untyped AST in sempass2 has been added to the check introduced in cef64c4 and accordingly a `knownIssue` testcase for the underlying issue --------- Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function readAllBuffer() always returned a string that was a
multiple of the BufSize in length, regardless of how many bytes were
actually read, padding the result with garbage bytes on the last chunk.
This fix properly trims the last chunk to its actual size. It also sets
BufSize to a value less likely to cause unnecessary overhead with C and
OS file I/O.