Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random shuffle #12396

Closed
wants to merge 2 commits into from

Conversation

@b3liever
Copy link
Contributor

commented Oct 9, 2019

rand has an inclusive upper bound, that means we need to subtract 1.

Edit:
Original code was: let j = random(i + 1) so this was always broken

Antonis added 2 commits Oct 9, 2019
Antonis
Antonis
@b3liever b3liever closed this Oct 9, 2019
@b3liever b3liever deleted the b3liever:fix-shuffle branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.