close #15767 #16959
Merged
close #15767 #16959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39f2f23.
timotheecour
reviewed
Feb 7, 2021
| if isFilled(s.data[h].hcode): yield s.data[h].key | ||
| if isFilled(s.data[h].hcode): | ||
| yield s.data[h].key | ||
| assert(len(s) == length, "the length of the HashSet changed while iterating over it") |
There was a problem hiding this comment.
DRY: how about use an auxiliary template:
template checkLen(a, b) =
const s = "the length of " & $type(a) & " changed while iterating over it"
assert len(a) == length, smakes it easy to change in 1 place (eg if we want to add runtime info $(len(a), length) for extended debugging)
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* fix some warnings * close nim-lang#15767 * Revert "fix some warnings" This reverts commit 39f2f23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR
sets.nim(910, 11)
len(s) == lengththe length of the OrderedSet changed while iterating over it [AssertionDefect]I keep the same behaviour as when iterating over tables/etc(I can fix other similar stuffs in the future's PRs if performance lossy is worthy).