locks and rlocks use destructors #18640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konsumlamm
reviewed
Aug 3, 2021
konsumlamm
reviewed
Aug 3, 2021
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
ringabout
commented
Aug 3, 2021
| initSysLock(lock.lock) | ||
|
|
||
| when useOrcArc: | ||
| proc `=sink`*(x: var Lock, y: Lock) {.error.} |
There was a problem hiding this comment.
|
The cause of CI failure seemed to be this: I will look into it some days later(for instance duplicate the test in the tests/stdlib directory instead). |
9 tasks
ringabout
changed the title
ringabout
changed the title
|
With this PR, locks and rlocks module can switch to destructors gradually. However it causes inconsistence between arc and refc implementation, users need to implement separate codes. Or it can be hidden under the umbrella of nimPreviewX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to adding destructors for Lock/Rlock/Cond for ARC/ORC and does less harm. It turns
deinitLock,deinitRlock,deinitCondinto a no-op and deprecates them. Then it also adds destructors for these objects.Same transition method could be applied to
Stream,File,socketor so if it were fine. It should cause less harm and less breaking changes. Then we don't need to closeFile,Streammanually.