Jump to conversation
Unresolved conversations (1)
@ringabout ringabout Aug 3, 2021
https://stackoverflow.com/questions/7557179/move-constructor-for-stdmutex
lib/core/locks.nim
Resolved conversations (15)
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitRLock` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `RLock`".} = ``` It would have been easier to just commit my proposed changes ;)
Outdated
lib/core/rlocks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion ## Nim lock, re-entrant. ```
Outdated
lib/core/rlocks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitCond` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `Cond`".} = ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitLock` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `Lock`".} = ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion ## Nim condition variable. ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
Should tests also test ORC?
Outdated
tests/stdlib/trlocks.nim
ringabout
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitRLock` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `RLock`".} = ```
Outdated
lib/core/rlocks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion RLock* = object ## Nim lock, re-entrant. ```
Outdated
lib/core/rlocks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion Cond* = object ## Nim condition variable. ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion Lock* = object ## Nim lock; whether this is re-entrant or not is unspecified! ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion RLock* = object ## Nim lock, re-entrant. lock: SysLock ```
Outdated
lib/core/rlocks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitCond` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `Cond`".} = ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion deprecated: "`deinitLock` is not needed anymore in ARC/ORC (it is a no-op now); `=destroy` is already defined for `Lock`".} = ```
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion Cond* = object ## Nim condition variable. cond: SysCond ``` We want the doc comment to be attached to the type.
Outdated
lib/core/locks.nim
@konsumlamm konsumlamm Aug 3, 2021
```suggestion Lock* = object ## Nim lock; whether this is re-entrant or not is unspecified! lock: SysLock ``` Otherwise the doc comment is attached to the field.
Outdated
lib/core/locks.nim
ringabout