Really fix StringStream with ARC at compile-time, improve streams test #19739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
linked an issue
ghost
commented
Apr 23, 2022
| result = s.readDataStrImpl(s, buffer, slice) | ||
| else: | ||
| # fallback | ||
| when declared(prepareMutation): |
There was a problem hiding this comment.
I didn't add a nimvm check here because this code branch isn't supported by the VM anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now tstreams is actually tested with ARC.
I also fixed
readDataStrbranch that is executed when thereadDataStrImplis nil so that it works with ARC (it's covered by the tstreams test).Also changed issue references in the test to the preferred convention.
Fixes #19716