remove deprecated type pragma syntax, fix bugs that required it #20199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
flyx
pushed a commit
to flyx/NimYAML
that referenced
this pull request
Aug 11, 2022
Sorry that this messes with the style here, but it would be nice to have this syntax removed given how long it's been deprecated (nim-lang/Nim#20199).
konsumlamm
reviewed
Aug 11, 2022
metagn
force-pushed
the
remove-bad-type-pragma-syntax
branch
from
3044a92 to
5a85d6b
Compare
metagn
changed the title
metagn
changed the title
metagn
changed the title
metagn
changed the title
|
PR changed to keep the syntax but remove it across the repo and change warning to say "legacy syntax" instead of deprecated. |
|
Please rebase. |
metagn
force-pushed
the
remove-bad-type-pragma-syntax
branch
from
db19bdd to
bb85c25
Compare
|
Done |
konsumlamm
reviewed
Aug 28, 2022
|
Will change later to remove the syntax and make |
closes nim-lang#4651, closes nim-lang#16653 with a cheap fix for now due to how early `tfFinal` is set
metagn
force-pushed
the
remove-bad-type-pragma-syntax
branch
from
fbb9a08 to
5416917
Compare
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
metagn
changed the title
|
The syntax is now removed with CI hacks to make certain packages work. (working around mratsim/weave#182 for weave, and fixes in sdl2 and variant not being in tagged versions) |
|
Thanks for your hard work on this PR! Hint: mm: orc; threads: on; opt: speed; options: -d:release |
ringabout
added a commit
that referenced
this pull request
Oct 4, 2022
Araq
pushed a commit
that referenced
this pull request
Oct 6, 2022
* correct grammar; ref #20199 * add check for keeping grammar.txt up-to-date * add nimTestGrammar
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…lang#20199) * remove deprecated pragma syntax from 0.20.0 closes nim-lang#4651, closes nim-lang#16653 with a cheap fix for now due to how early `tfFinal` is set * remove type pragma between name and generics * undo removal, try removing bind expression (0.8.14) * fix test, unremove bind expr * remove again * Update changelog.md Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com> * dependencies @ HEAD & weave test dependencies * try fix package ci Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…im-lang#20494) * correct grammar; ref nim-lang#20199 * add check for keeping grammar.txt up-to-date * add nimTestGrammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4651, closes #16653 with a cheap fix for now due to how early
tfFinalis setRemoves
type Foo = object {.final.}/type Foo {.final.} [T] = objectsyntax, remove uses of the syntax in this repo.Packages which still use this syntax:
sdl2(fixed in untagged release 2.0.4)yaml(merged Change deprecated type pragma syntax flyx/NimYAML#118)variant(merged change deprecated type pragma position yglukhov/variant#9)Note: Also tested removing bind expression syntax deprecated since 0.8.14 and no code was affected. Searching for nnkBind on github also gives zero user code results, so macros don't use this syntax either.