Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecated warnings for {.deadcodeelim: on.} #21277

Merged
merged 2 commits into from Feb 16, 2023
Merged

add deprecated warnings for {.deadcodeelim: on.} #21277

merged 2 commits into from Feb 16, 2023

Conversation

ringabout
Copy link
Member

Lots of C wrappers generated by old version c2nim use {.deadcodeelim: on.}. It would be better to warn its deprecation in case of confusion.

@Varriount Varriount requested a review from Araq January 23, 2023 22:46
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Jan 23, 2023
@ringabout ringabout merged commit 93e4f27 into devel Feb 16, 2023
16 checks passed
@ringabout ringabout deleted the pr_deadcode branch February 16, 2023 05:34
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 93e4f27

Hint: mm: orc; opt: speed; options: -d:release
166141 lines; 8.419s; 611.176MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants