Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #18134; registers formatBiggestFloat in VM #21299

Merged
merged 1 commit into from Jan 26, 2023
Merged

fixes #18134; registers formatBiggestFloat in VM #21299

merged 1 commit into from Jan 26, 2023

Conversation

ringabout
Copy link
Member

fixes #18134

std/strformat now supports float format in VM

strformat supports float format in VM
@Varriount Varriount requested a review from Araq January 25, 2023 20:39
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Jan 25, 2023
@Araq Araq merged commit fc068ee into devel Jan 26, 2023
22 checks passed
@Araq Araq deleted the pr_vm_printf branch January 26, 2023 22:04
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fc068ee

Hint: mm: orc; opt: speed; options: -d:release
166208 lines; 8.229s; 611.207MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
…21299)

fixes nim-lang#18134; registers formatBiggestFloat in vmops

strformat supports float format in VM
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
…21299)

fixes nim-lang#18134; registers formatBiggestFloat in vmops

strformat supports float format in VM
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
…21299)

fixes nim-lang#18134; registers formatBiggestFloat in vmops

strformat supports float format in VM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

&"{1.236:<.2}" doesn't work in VM.
3 participants