Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #21360; discarding empty seqs/arrays now raises errors #21374

Merged
merged 2 commits into from Feb 16, 2023
Merged

fixes #21360; discarding empty seqs/arrays now raises errors #21374

merged 2 commits into from Feb 16, 2023

Conversation

ringabout
Copy link
Member

fixes #21360

@ringabout ringabout changed the title fixes #21360; discarding empty seqs now raises errors fixes #21360; discarding empty seqs/arrays now raises errors Feb 15, 2023
@Araq Araq added the merge_when_passes_CI mergeable once green label Feb 15, 2023
@Araq
Copy link
Member

Araq commented Feb 15, 2023

It's better than before, yet all wrong. The problem is not that you must not discard @[], the problem is that @[] is not a value in itself of sufficiently concrete type.

@tersec
Copy link
Contributor

tersec commented Feb 15, 2023

Sure, filed a followup: #21377

@ringabout ringabout merged commit fc7385b into devel Feb 16, 2023
16 checks passed
@ringabout ringabout deleted the pr_discard_empty_seqs branch February 16, 2023 02:23
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fc7385b

Hint: mm: orc; opt: speed; options: -d:release
166140 lines; 8.913s; 611.176MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
@ringabout @survivorm
fixes nim-lang#21360; discarding empty seqs/arrays now raises errors (n…
3c79073 
…im-lang#21374)

* discarding empty seqs now raises errors

* the same goes for sets
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#21360; discarding empty seqs/arrays now raises errors (n…
8d8ec20 
…im-lang#21374)

* discarding empty seqs now raises errors

* the same goes for sets
narimiran pushed a commit that referenced this pull request Apr 26, 2023
@ringabout @narimiran
fixes #21360; discarding empty seqs/arrays now raises errors (#21374)
ef32c02 
* discarding empty seqs now raises errors

* the same goes for sets

(cherry picked from commit fc7385b)
narimiran pushed a commit that referenced this pull request Apr 26, 2023
@ringabout @narimiran
fixes #21360; discarding empty seqs/arrays now raises errors (#21374)
025ada1 
* discarding empty seqs now raises errors

* the same goes for sets

(cherry picked from commit fc7385b)
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
fixes nim-lang#21360; discarding empty seqs/arrays now raises errors (n…
f021039 
…im-lang#21374)

* discarding empty seqs now raises errors

* the same goes for sets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: internal error: cannot map the empty seq type to a C type with @[]
3 participants
@ringabout @Araq @tersec