Guard against calling split with an empty string as a separator. Fixe… #5125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Dec 17, 2016
lib/pure/strutils.nim
Outdated
| ## `split iterator <#split.i,string,string>`_. | ||
| ## | ||
| ## If `sep` is an empty string, `ValueError` is raised. | ||
| if sep.len == 0: |
There was a problem hiding this comment.
API usage errors should be signaled via assert.
chrisheller
force-pushed
the
fix-issue-5119
branch
from
2e77a00 to
40d034b
Compare
|
Thanks but now your added test case fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s #5119