Fixed implementation of select() #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated ftpclient, irc and scgi to take fix into account
|
So, what about sockets does this fix? |
|
when select(readFds, writeFds, errorFds) returns, it is meant to leave any readFds/writeFds/errorFds in their corresponding sets iff the socket is available, the way it's implemented in nimrod's sockets.nim module is backwards, so if, for example, you pass in your listening socket into readFds, readFds DOESNT contain the listening socket IF the socket is ready to be read. |
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary This fixes a legacy reports bug, where the migration stopped program termination even when requiring a main module to exist. This now works and a more approriate error message is provided instead of a path error. ## Details `modules.wantMainModule` now generates an `rextCmdRequiresFile` (new legacy report kind), which is treated as a fatal error by `options.isCompilerFatal`. In addition a quick tests was added to ensure this continues to function going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ftpclient, irc and scgi to take fix into account