Install uncaught exception handler in cpp (#6512) #6893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a test case. |
|
@Araq is there a good example test of fatal behavior I can base it on? Also, how do I mark the test as c++ only? |
|
You can probably base it on this: https://github.com/nim-lang/Nim/blob/devel/tests/exception/tunhandledexc.nim And these C++ tests show how to target the |
RedBeard0531
force-pushed
the
cpp_unhandled_exception
branch
from
125b3de to
f474749
Compare
|
@Araq test added |
|
Tests fail. Also, this doesn't work on assertion failures (I tested it). |
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to match the behavior of the c codegen. Let me know if there is a better place to put this code.