Updated cfg file processing #697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in user-defined type classes
No longer look at deprecated file.cfg, compiler will only look at file.nimrod.cfg
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary `nkNimNodeLit` are no longer scanned during var capture detection, ensuring that literals do not alter capture analysis of a routine holding typed literal AST with symbols from the outer routine. ## Details Capture detection is done in two modules `lambdalifting` and `sempass2` in the `detectCapturedVars` and `detectCapture` procedures, respectively. With this change both procedures do not traverse into `nkNimNodeLit` (treating them as more opaque literal data) for literal analysis. A regression tests has been added a test for this (thanks to Zerbina). --------- Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer look at deprecated file.cfg, compiler will only look at file.nimrod.cfg