Remove obsolete method analyzeAndConsolidateOutput #6998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change, when stacktraces rendered in reversed order (most recent call first), this method removed all stacktraces in the test failures.
Was this changed in Nim? Are stack traces rendered this way now? |
|
I meant, that in the past this code used to find beginning of stacktrace, and copied it into output buffer, but now, when stacktraces go in reversed order, it cannot find the marker substrings, and just return empty buffer. "After the change..." means "After the changing stacktrace rendering", and it already in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change, when stacktraces rendered in reversed order (most recent
call first), this method removed all stacktraces in the test failures.