Add warnings about deprecation to times module #7001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 30, 2017 18:10
I've added warnings about some procedures being deprecated. Also I can't find what is the replacement for `getTimezone` proc, please help with that
|
@GULPF - can you please tell what is the replacement for |
ghost
deleted the
|
This is incorrect - the replacement for toSeconds/fromSeconds is toUnix/fromUnix. Casting to/from Time will break when my current PR is merged, so it’s not a good idea (Time is spposed to be an opaque type). getTimezone doesn’t have a direct replacement, as it does different things depending on backend/platform - one of the reasons why it’s deprecated. |
|
@GULPF well I based warnings on proc code |
|
@Yardanico No worries, I should have added the comments when I deprecated the procs. Fixed in #7005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added warnings about some procedures being deprecated.
Also I can't find what is the replacement for
getTimezoneproc, please help with that