Make quoteIfContainsWhite quote argument, so it can be safely passed to shell.

[zielmicha]

On Windows put it in double quotes and escape double quotes using backslash.
On Posix put it in single quotes and escape single quotes using '"'"'.

This commit changes what quoteIfContainsWhite does, but before that change it was used incorrectly all over standard library, which caused security issues.

[dom96]

I'm not sure this is the correct solution. quoteIfContainsWhite is not a proc exclusively intended for osproc, perhaps you should leave quoteIfContainsWhite alone and introduce a new proc with your new implementation.

[zielmicha]

This might be better idea. However this will also require changing 27 places where it is used with intent of quoting shell command and will leave original one without any uses.

[zielmicha]

I mean, if we leave quoteIfContainsWhite as is, people will keep using it as shell escaping routine, leading to security issues.

By the way, #701 is related.

[Araq]

I agree with zielmicha. In fact, I consider it a simple oversight of quoteIfContainsWhite. So please fix quoteIfContainsWhite and document its new behaviour and also document this change in web/news.txt.

[zielmicha]

Added info to web/news.txt.

[gradha]

This change seems to break rst2html invoked during koch web:

nimrod rst2html --compileonly --hint[Conf]:off --putenv:nimrodversion=0.9.3 --path:/Users/gradha/project/nimrod/root -o:web/index.temp web/index.txt
Error: arguments can only be given if the '--run' option is selected

[zielmicha]

Ok, I think it breaks the use of [] in arguments - I just had the same problem with compiler.

I think I know what's wrong: argument parser must be using quoteIfWhite and then checks for "--", because it fails in a same way when given parameter containing spaces (on older 0.9.2)