Fix #7212 #7220
Closed
Fix #7212 #7220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Feb 14, 2018
lib/system/dyncalls.nim
Outdated
|
|
||
| proc nimLoadLibraryError(path: string) = | ||
| when defined(guiapp): | ||
| discard MessageBoxA(0, msg, "could not load: " & path, 0) |
There was a problem hiding this comment.
This uses & which uses the GC. Boehm GC is loaded as a DLL --> crash if Boehm cannot be loaded. You need to use some low level stuff to fill an array[Size, char] and pass that to MessageBoxA. Also MessageBoxA is already declared in excpt.nim.
|
@Araq Now it should be good, please review again. |
Araq
reviewed
Feb 26, 2018
lib/system/dyncalls.nim
Outdated
| proc nimGetProcAddr(lib: LibHandle, name: cstring): ProcAddr {. | ||
| error: "nimGetProcAddr not implemented".} | ||
|
|
||
| proc nimLoadLibraryError(path: string) = {. |
There was a problem hiding this comment.
This is wrong, don't mess with the genode path please.
Araq
reviewed
Mar 2, 2018
|
|
||
| proc nimLoadLibraryError(path: string) = | ||
| # carefully written to avoid memory allocation: | ||
| when defined(guiapp): |
There was a problem hiding this comment.
when defined(windows) and defined(guiapp)
and then you can merge the two nimLoadLibraryError implementations.
|
Sorry, my code was bad, I will redo it in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I look up, how an error message for an unhanded exception is thrown in excpt.nim, and changed dyncalls.nim to the same behavior.