move readPasswordFromStdin from rdstdin to terminal
#7266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the `readPasswordFrom` from the rdstdin to the terminal module. This gets rid of the linenoise dependency, which is not required for the proc.
Sets "password: " as a sensible default for the prompt in the `readPasswordFromStdin` proc
Vindaar
force-pushed
the
pr/moveReadPassword
branch
from
5f9ae03 to
55b6049
Compare
|
The commit "replace |
|
Ok, it's what I did at first, but I felt that replacing all occurrences became a little to verbose. I'll undo it. :) |
|
Well you can introduce a helper template here. |
In order to comply with taint mode, we need to convert the password variable in `readPasswordFromStdin` to a string, before we can set its length.
Vindaar
force-pushed
the
pr/moveReadPassword
branch
from
06ac793 to
913db49
Compare
|
You mean like an inline template such as: template pword: untyped = password.string? |
|
yes |
|
Unrelated test failures, merging anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
readPasswordFromStdinproc from therdstdinto theterminalmodule. This way the proc is not dependent onlinenoiseanymore, which it does not use anyways.I had to convert the
passwordvariable (TaintedStringargument of the proc) manually to a string, beforesetLenis called. Otherwise the call fails in taint mode.