Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Mar 1, 2018

No description provided.

@ghost
Copy link

ghost commented Mar 1, 2018

I think it may be better to generate this table directly in "fac" proc, so if user doesn't use "fac" compiler doesn't create these?

@ghost
Copy link
Author

ghost commented May 2, 2018

@Araq, @dom96, someone, please review.

@survivorm
Copy link
Contributor

Looks like a sound idea, no improvements coming into mind

@dom96
Copy link
Contributor

dom96 commented May 3, 2018

This depends on a couple of factors:

  • Does this affect compile-time when I am importing math but not using fac?

  • When fac is used how much slower is the compilation?

  • How much does this affect the binary size?

@ghost
Copy link
Author

ghost commented May 3, 2018

@dom96 1) I think not but I don't know if this or my previous commit is the right way.
2) none at all. It only creates a table of 21 integers. 3) +168 bytes I guess?

@Araq Araq merged commit 8f7bd6c into nim-lang:devel May 4, 2018
@ghost
Copy link

ghost commented May 11, 2018

@NotTito sorry, I didn't notice it earlier - why did you remove ability to call fac with 0?

@ghost
Copy link
Author

ghost commented May 16, 2018

@Yardanico can someone with access fix it, sry I dont have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants