Renamed jsondoc2 to jsondoc, similar to doc2 #7279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMunch
force-pushed
the
jsondoc
branch
2 times, most recently
from
b025f38 to
a161d80
Compare
|
Since doc2 became just doc, could this be done for jsondoc too? |
|
Hmm, yeah I guess it would make sense to do the same change to jsondoc |
PMunch
changed the title
|
Renamed jsondoc2 now, and updated the information on doc2 which was still talking about doc2 and doc. |
|
Superb work, but I haven't reviewed it carefully yet. |
Araq
reviewed
Mar 8, 2018
doc/docgen.rst
Outdated
| commands. These command take either a single .nim file, outputting a single | ||
| .html file with the same base filename, or multiple .nim files, outputting | ||
| multiple .html files and, optionally, an index file. | ||
| Generation of HTML documents is done via both the ``doc`` command. This command |
Araq
reviewed
Mar 8, 2018
doc/docgen.rst
Outdated
| .html file with the same base filename, or multiple .nim files, outputting | ||
| multiple .html files and, optionally, an index file. | ||
| Generation of HTML documents is done via both the ``doc`` command. This command | ||
| take either a single .nim file, outputting a single .html file with the same |
Araq
reviewed
Mar 8, 2018
doc/docgen.rst
Outdated
| module(s), which allows it to process macros. | ||
| The full output can be seen here: `docgen_sample2.html <docgen_sample2.html>`_. | ||
|
|
||
| The previous ``doc`` command, now renamed ``doc0`` runs before semantic checking |
There was a problem hiding this comment.
"The older version of the doc command"
|
Also needs a changelog entry. |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 8, 2018
Mainly spelling and syntax errors, after review from Araq ref: nim-lang#7279
PMunch
added a commit
to PMunch/Nim
that referenced
this pull request
Mar 8, 2018
Mainly spelling and syntax errors, after review from Araq ref: nim-lang#7279
Manual was missing information about jsondoc2 which made it seem like it didn't exist at all. This commit adds mention of the jsondoc2 command along with an example.
doc2 was recently renamed to doc while doc was renamed to doc0. This commits renames jsondoc to jsondoc2 and jsondoc2 to jsondoc0 to behave tha same way. The documentation for doc/jsondoc was also lagging behind this change which has also been fixed. I interpreted this as a soft deprecation of doc and jsondoc and therefore removed them from the auto-complete lists.
Mainly spelling and syntax errors, after review from Araq ref: nim-lang#7279
zah
pushed a commit
to zah/grip-lang
that referenced
this pull request
Mar 19, 2018
* Update information about jsondoc/jsondoc2 Manual was missing information about jsondoc2 which made it seem like it didn't exist at all. This commit adds mention of the jsondoc2 command along with an example. * Renamed jsondoc2 similar to doc2 and updated docs doc2 was recently renamed to doc while doc was renamed to doc0. This commits renames jsondoc to jsondoc2 and jsondoc2 to jsondoc0 to behave tha same way. The documentation for doc/jsondoc was also lagging behind this change which has also been fixed. I interpreted this as a soft deprecation of doc and jsondoc and therefore removed them from the auto-complete lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual was missing information about jsondoc2 which made it seem like
it didn't exist at all. This commit adds mention of the jsondoc2
command along with an example.