Make parseopt correct (and based on seq[string] as parameters, not string) #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't edit it - trick with asking git to ignore whitespace doesn't work if I need to change indention level.
commandLineParams returns seq of arguments given to program on command line.
…rings, not single string.
|
Maybe it's getting there, but there still are problems running It seems that the |
|
It doesn't. Option is split on = before :. I guess I need to change priority. |
|
It should work now. Btw |
Araq
added a commit
that referenced
this pull request
Dec 10, 2013
Make parseopt correct (and based on seq[string] as parameters, not string)
reactormonk
pushed a commit
to reactormonk/nim
that referenced
this pull request
Apr 7, 2014
This reverts commit a54ba4c to avoid tool breakage. A different approach is being worked on nim-lang#730.
reactormonk
pushed a commit
to reactormonk/nim
that referenced
this pull request
Apr 7, 2014
Make parseopt correct (and based on seq[string] as parameters, not string)
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
## Summary Create a copy of the token before calling `parsePragma` in `identWithPragma`, which fixes a subtle issue where the `Token.literal` string pointed to already-freed heap memory. ## Details For a call such as `p(a, p2(a))` where `proc p(x: ObjType)` and `proc p2(x: var ObjType)`, the *C code-generator* introduces a shallow temporary that captures the state of `a` prior to the evaluating `p2(a)`, with the temporary then being passed to `p` in the place of `a`. This is done in order to uphold the left-to-right evaluation guarantees. However, if the `ObjType` stores indirections such as `seq` or `string`, updates of their contents are still observable through the shallow temporary, and should `p2` resize the `seq` or `string`, the pointer in the shallow temporary becomes dangling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #726, possibly #274, and fixes regression introduced by #702. And I hope it doesn't break new things.
Sorry for "Normalize whitespace in os.nim", but I'd rather spend time fixing Nimrod, than doing nasty tricks in bash or reconfiguring my editor. (and we all don't like trailing whitespace?)
New code in
parseopt.nimadheres to the following "specification":There is also a new test -
tests/system/params.nim. I'm not sure if it works on Windows.